Use VS Code FS API #6911

Activity

1. Don Jayamanne (DonJayamanne)

   added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Aug 8, 2019
2. Brett Cannon (brettcannon)

   added

   importantIssue identified as high-priorityIssue identified as high-priority

   needs PR

   on Aug 12, 2019
3. ghost removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Aug 12, 2019
4. Brett Cannon (brettcannon)

   added

   feature-*

   debtCode quality issuesCode quality issues

   on Aug 12, 2019
5. Don Jayamanne (DonJayamanne)

   added this to the 2019 - August Sprint 16 milestone on Aug 14, 2019
6. karrtikr commented on Aug 28, 2019

   

   Kartik Raj (karrtikr)

   on Aug 28, 2019

   Last edited by karrtikr

   More actions

   Try to use the vscode.workspace.fs API instead of fs and fs-extra wherever we can.

   For the things that we can't do with the API, make a list of those things and open issues in vscode.
7. Kartik Raj (karrtikr)

   modified the milestones: 2019 - August Sprint 16, September sprint 2019.1 on Aug 28, 2019
8. Eric Snow (ericsnowcurrently)

   removed this from the September sprint 2019.1 milestone on Sep 16, 2019
9. Karthik Nadig (karthiknadig)

   added this to the 2019 - October Sprint 1 milestone on Sep 25, 2019
10. Eric Snow (ericsnowcurrently)

    self-assigned this

    on Oct 7, 2019
11. Karthik Nadig (karthiknadig)

    modified the milestones: 2019 - October Sprint 1, 2019 October Sprint 2 on Oct 9, 2019
12. Karthik Nadig (karthiknadig)

    modified the milestones: 2019 October Sprint 2, 2019 October Sprint 3 on Oct 23, 2019
13. Brett Cannon (brettcannon)

    changed the title [-]Use VS Code FS Api[/-] [+]Use VS Code FS API[/+] on Oct 24, 2019
14. Graham Wheeler (gramster)

    added

    in progress

    on Oct 29, 2019
15. Karthik Nadig (karthiknadig)

    modified the milestones: 2019 October Sprint 3, 2019 November Sprint 1 on Nov 6, 2019
16. ericsnowcurrently commented on Nov 11, 2019

    

    Eric Snow (ericsnowcurrently)

    on Nov 11, 2019

    Last edited by ericsnowcurrently

    More actions

    I've opened upstream issues.

    bugs:

    • unexpected successes - vscode.workspace.fs.remove() (and copy()) succeed unexpectedly. vscode#84177
    • FileStat time resolution - vscode.workspace.fs.stat(): FileStat only has 1 second resolution. vscode#84526
      • not actually a problem (node provides nanosecond resolution)
    • FileStat.ctime == 0 - vscode.workspace.fs.stat(): wrong creation time. vscode#84525
    • sockets as FileType.File - vscode.workspace.fs.stat(): sockets identified as "regular" files. vscode#84524

    feature requests:

    • original - Add more functionality to the "vscode.workspace.fs" API. vscode#84175
    • chmod() - Add vscode.workspace.fs.chmod(). vscode#84513
      • covered by Enable FileSystemProvider to stat a file as readonly vscode#73122 and FileSystemProvider: no way of handling permissions issues vscode#48659
    • lstat() - Support stat() for symbolic links themselves. vscode#84514
      • covered by File Provider: support symbolic link operations vscode#71204
    • createWriteStream() - Add vscode.workspace.fs.createWriteStream(). vscode#84515
      • coming but still in design stage
    • mkdirp() - Add vscode.workspace.fs.mkdirp(). vscode#84516
      • "createDirectory() already does this; the docs need to be updated"
    • mkdtemp() - Add vscode.workspace.fs.mkdtemp(). vscode#84517
    • sync API - Support for sync functions in the vscode.workspace.fs API. vscode#84518
      • not going to happen
    • glob() - Add more functionality to the "vscode.workspace.fs" API. vscode#84175
      • "use vscode.workspace.findFiles()"
17. ericsnowcurrently commented on Nov 12, 2019

    

    Eric Snow (ericsnowcurrently)

    on Nov 12, 2019

    More actions

    Any workarounds or missing functionality is covered in #8533.
18. Eric Snow (ericsnowcurrently)

    modified the milestones: 2019 November Sprint 1, 2019 November Sprint 2 on Nov 20, 2019
19. Eric Snow (ericsnowcurrently)

    added 2 commits that reference this issue on Nov 26, 2019

    Update the code base to use IFileSystem instead of fs and fs-extra. (#…

    ...

    a23761d

    Use new VS Code filesystem API. (#8307)

    ...

    7cbd1c2
20. Karthik Nadig (karthiknadig)

    closed this as completedon Nov 26, 2019
21. ghost removed

    needs PR

    on Nov 26, 2019
22. lock

    locked as resolved and limited conversation to collaborators on Dec 3, 2019