Repository navigation
Upgrade bundled Jedi #674
Description
Activity
We've looked the a previous version of Jedi, however there were a number of breaking changes.
This was looked at as part of #171TODO: Guess its time to review this once again.
+1 on this one, I know there's been a large number of fixes and improvements in recent versions. I've also had trouble in the past using anything but the bundled version of Jedi, not sure if these issues have been addressed lately or not.
It looks like another version might be ready for a release soon (davidhalter/jedi#1031 (comment)) so maybe it's worth waiting a little more for it (though there is a risk to get stuck in such waiting for a while).
Mikhail Arkhipov (@MikhailArkhipov) I think I spot a few issues with the upgrade:
- I think you left old files from a previous version of Jedi.
- Jedi know depends on Parso, which is missing.
- You default to the "preview" version https://github.com/Microsoft/vscode-python/blob/601546884d8e23bb941eb955b697b02f2426e675/src/client/providers/jediProxy.ts#L291-L299 rather than the new version which was placed in "stable" (I think that's a hidden config setting...).
I can open a separate issue if you want.
Opened #773. Thanks for the pointers.
- locked as resolved and limited conversation to collaborators
on Jul 12, 2018
Environment data
VS Code version: 1.19.3
Python Extension version: 0.9.1
Python Version: 2.7.12
OS and version: Ubuntu 16.04.3 x64
Jedi 1.11.1 is available. Might want to consider upgrading, assuming that the new version is better...
Note that it now depends on parso which will also need to be included.