Skip to content

Fix indent/dedent for "return" syntax. #6564

Closed

Description

While working on #6333, the dedent regex was kept simple for the return keyword (see #6497 (comment)), but didn't cover the case for return followed by a dangling [, ( or { before the cursor.

This issue also covers restoring the dedent removed for #6813 (added for #6333).

Current (pre-#6813) behaviour (merged in #6497):

current

Expected/desired behaviour:

expected

Activity

  1. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on Jul 12, 2019
  2. changed the title [-]Improve indentation rule for return statement followed by a dangling [, { or ([/-] [+]Spike - Improve indentation rule for return statement followed by a dangling [, { or ([/+] on Jul 17, 2019
  3. changed the title [-]Spike - Improve indentation rule for return statement followed by a dangling [, { or ([/-] [+]Remove return statement support[/+] on Jul 29, 2019
  4. changed the title [-]Remove return statement support[/-] [+]Fix indent/dedent for "return" syntax.[/+] on Aug 1, 2019
  5. DonJayamanne commented on Aug 14, 2019

    @DonJayamanne

    Prescribed Solution:

  6. brettcannon commented on Aug 21, 2019

    @brettcannon
    Member

    The original PR was reverted, so there's nothing to fix here as long as we don't bring this feature back.

  7. locked as resolved and limited conversation to collaborators on Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions