Dedent else:

E.g.

if True:
   print()
   else: # Pressing 'enter' should dedent this line.

Prescribed solution

Make sure vscode provides the functionality to - dedent the line we are editing.
If there is one, use it.

This may not be possible currently. VSCode has the following API that we use in extension.ts:

https://code.visualstudio.com/api/references/vscode-api#LanguageConfiguration

We currently use onEnterRules, but indentationRules is another option. However, neither lets you indent the current line.

upstream: microsoft/vscode#66235

Turns out that Ruby has support through their language configuration file. It seems if you define a symbol for both indent and dedent (e.g. elsif or else) it will dedent the line but then begin indenting the next line. Not sure if this will work with how we currently do it:

vscode-python/src/client/extension.ts

Lines 179 to 198 in 796169c

    
           onEnterRules: [ 
        
               { 
        
                   beforeText: /^\s*(?:def|class|for|if|elif|else|while|try|with|finally|except|async)\b.*:\s*/, 
        
                   action: { indentAction: IndentAction.Indent } 
        
               }, 
        
               { 
        
                   beforeText: /^(?!\s+\\)[^#\n]+\\\s*/, 
        
                   action: { indentAction: IndentAction.Indent } 
        
               }, 
        
               { 
        
                   beforeText: /^\s*#.*/, 
        
                   afterText: /.+$/, 
        
                   action: { indentAction: IndentAction.None, appendText: '# ' } 
        
               }, 
        
               { 
        
                   beforeText: /^\s+(continue|break|return)\b.*/, 
        
                   afterText: /\s+$/, 
        
                   action: { indentAction: IndentAction.Outdent } 
        
               } 
        
           ]

If it won't work there then we should probably look at modernizing our configuration and switch over to the similar configuration file (the extension predates it).

We should open a bug against the VS Code docs to document the else trick so no one else has to try and discover that as well.

Looks good:

# dedent

if True:
    break
if True:
    continue
if True:
    pass
if True:
    raise
if True:
    raise spam
if True:
    return
if True:
    return None
if True:
    return {}
if True:
    return {

# indent

spam\
    eggs
    # keeps indenting
if True:
    ...
while True:
    ...
for x in spam:
    ...
try:
    ...
with spam:
    ...
def spam():
    ...
def spam:  # no parens
    ...
class spam:
    ...
class spam():
    ...
async def spam():
    ...
async for x in spam:
    ...
async with spam:
    ...

# dedent + indent
if True:
    ...
elif False:  # dedented
    ...
else:  # dedented
    ...
try:
    ...
except Exception:  # dedented
    ...
except:  # dedented
    ...
else:  # dedented
    ...
for x in spam:
    ...
else:  # dedented
    ...
while True:
    ...
else:  # dedented
    ...

https://devblogs.microsoft.com/python/python-in-visual-studio-code-december-2022-release/#auto-indentation-with-pylance 🎉

Navigation Menu

Repository navigation

Dedent `else:` #6333

Prescribed solution

4 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onEnterRules: [
	{
	beforeText: /^\s(?:def\|class\|for\|if\|elif\|else\|while\|try\|with\|finally\|except\|async)\b.:\s*/,
	action: { indentAction: IndentAction.Indent }
	},
	{
	beforeText: /^(?!\s+\\)[^#\n]+\\\s*/,
	action: { indentAction: IndentAction.Indent }
	},
	{
	beforeText: /^\s#./,
	afterText: /.+$/,
	action: { indentAction: IndentAction.None, appendText: '# ' }
	},
	{
	beforeText: /^\s+(continue\|break\|return)\b.*/,
	afterText: /\s+$/,
	action: { indentAction: IndentAction.Outdent }
	}
	]

Dedent else: #6333

Description

Activity

karrtikr commented on Jun 26, 2019

Prescribed solution

ericsnowcurrently commented on Jun 26, 2019

ericsnowcurrently commented on Jun 26, 2019

brettcannon commented on Jul 2, 2019

4 remaining items

brettcannon commented on Jul 12, 2019

ericsnowcurrently commented on Jul 15, 2019

brettcannon commented on Dec 13, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Dedent `else:` #6333