Multi-workspace doesn't display correct python interpreter if a file that's open is different from the root

Steps to reproduce:

Open multi workspace
Open two files from two different folders
Set python interpreter to be different for each
Close workspace
Reopen

One of the files will show the wrong interpreter (might have to switch which one is active by default to get it to repro)

Bug is in line 158 of extension.ts .

    interpreterManager.refresh(workspaceService.hasWorkspaceFolders ? workspaceService.workspaceFolders![0].uri : undefined)
        .catch(ex => console.error('Python Extension: interpreterManager.refresh', ex));

When the workspace is reopened, the extension is told to always use the first workspace folder workspaceService.workspaceFolders![0].uri to refresh interpreters instead of using the "Active resource" to get the workspace folder.

The following code in activationManager.ts provides that.

    private getActiveResource(): Resource {
        if (this.documentManager.activeTextEditor && !this.documentManager.activeTextEditor.document.isUntitled) {
            return this.documentManager.activeTextEditor.document.uri;
        }
        return Array.isArray(this.workspaceService.workspaceFolders) && workspace.workspaceFolders!.length > 0
            ? workspace.workspaceFolders![0].uri
            : undefined;
    }

✅ Works now:

first venv (opened by default)	second venv	third venv

Navigation Menu

Repository navigation

Multi-workspace doesn't display correct python interpreter if a file that's open is different from the root #6282

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Multi-workspace doesn't display correct python interpreter if a file that's open is different from the root #6282

Description

Activity

karrtikr commented on Jun 28, 2019

kimadeline commented on Sep 28, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions