You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering about this because linter errors often come up when editing.
Is this really an important, realistic goal? There are 1,763 errors from hygiene when run on the whole project, last I checked. Maybe fixing errors on each file as they are modified is more realistic.
To help manage our issues and to better communicate what the team plans to work on we are closing issues that we don't plan to work on but would accept a pull request from a volunteer for. To be clear, closing this issue does not mean we won't consider a pull request for this enhancement as outlined in our contributing guide, just that the development team has no plans to work on it themselves.
Activity
elliott-beach commentedon Feb 4, 2018
I was wondering about this because linter errors often come up when editing.
Is this really an important, realistic goal? There are 1,763 errors from
hygienewhen run on the whole project, last I checked. Maybe fixing errors on each file as they are modified is more realistic.DonJayamanne commentedon Feb 4, 2018
That's been taken care of. Thats the current behavior.
The goal is to ensure PRs get rejected if linting falls. And we need to fix all errors,.
DonJayamanne commentedon Feb 4, 2018
elliott-beach commentedon Feb 4, 2018
I might be confused, I'm referring to output of
gulp hygiene, this is the output I get (ignoring warnings) https://gist.github.com/elliott-beach/2d3e76bff4cb1ff0355afee3d95704c5brettcannon commentedon Sep 20, 2018
To help manage our issues and to better communicate what the team plans to work on we are closing issues that we don't plan to work on but would accept a pull request from a volunteer for. To be clear, closing this issue does not mean we won't consider a pull request for this enhancement as outlined in our contributing guide, just that the development team has no plans to work on it themselves.
9 remaining items