Activity

1. Don Jayamanne (DonJayamanne)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   needs PR

   debtCode quality issuesCode quality issues

   area-terminal

   feature-interpreter

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Jun 13, 2019
2. ghost removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Jun 13, 2019
3. Don Jayamanne (DonJayamanne)

   removed

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   on Jun 13, 2019
4. Don Jayamanne (DonJayamanne)

   changed the title [-]Use `conda run ...` to get environment variables[/-] [+]Use `conda run ...`[/+] on Jun 14, 2019
5. DonJayamanne commented on Aug 14, 2019

   

   Don Jayamanne (DonJayamanne)

   on Aug 14, 2019

   Last edited by karrtikr

   Author

   More actions

   conda run <env name> python <xyz.py>

   The issue comes from spike #5664
6. Don Jayamanne (DonJayamanne)

   added this to the 2019 - August Sprint 16 milestone on Aug 14, 2019
7. karrtikr commented on Aug 28, 2019

   

   Kartik Raj (karrtikr)

   on Aug 28, 2019

   Last edited by ericsnowcurrently

   More actions

   Prescribed solution

   • communicate to the (old) debug adapter the path to conda
   • use "conda run" in the (old) debug adapter
     • see https://github.com/Microsoft/vscode-python/blob/85ea1b546bf0461dd019270de24fbbe4ac2f335a/src/client/debugger/debugAdapter/DebugClients/LocalDebugClient.ts#L149
   • do not "auto activate" if it's the debug adapter terminal
     • see https://github.com/Microsoft/vscode-python/blob/86d669e3906c533bb6f674b1745ce90389b8e75a/src/client/terminals/activation.ts
     • when the name is equal to 'Python Debug Console' (if not, research some other means by which we can identify if it is the 'Python Debug Console'), we do not send the activation commands.

   questions:

   • how to communicate the conda path to the debug adapter? See option 2 in Spike - Activation script sent to terminal after debugger starts (Use Conda run) #5664 (comment).
   • use "conda run" elsewhere in the extension? (only needed in cases where we need to run a command and can only send one; e.g. debug adapter)
8. ericsnowcurrently commented on Aug 28, 2019

   

   Eric Snow (ericsnowcurrently)

   on Aug 28, 2019

   More actions

   FYI, all other env types are fine because using the python executable directly is equivalent to activating first. Conda doesn't work like that and requires activation.

   Also, keep in mind that the key objective of this issue is to resolve the race condition in env activation when we launch the debugger.
9. DonJayamanne commented on Aug 29, 2019

   

   Don Jayamanne (DonJayamanne)

   on Aug 29, 2019

   Author

   More actions

   Partial PR #6959
10. DonJayamanne commented on Aug 29, 2019

    

    Don Jayamanne (DonJayamanne)

    on Aug 29, 2019

    Author

    More actions

    communicate to the (old) debug adapter the path to conda
    use "conda run" in the (old) debug adapter

    With the new DA coming in as an experiment, do we need to consider adding support for conda run for the old debugger. I don't see much value in this.
    Basically It's a lot of work, that'll be thrown away.

    use "conda run" elsewhere in the extension? (only needed in cases where

    Please see the PR mentioned earlier, changes to the factory class works would suffice (i.e. change one place, the factory class)
11. 9 remaining items

    Load more
12. Eric Snow (ericsnowcurrently)

    changed the title [-]Use `conda run in the debug adapter`[/-] [+]Use `conda run` in the debug adapter[/+] on Sep 25, 2019
13. Karthik Nadig (karthiknadig)

    removed

    metaIssue that is tracking an overall projectIssue that is tracking an overall project

    on Sep 25, 2019
14. ghost added

    triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

    on Sep 25, 2019
15. Karthik Nadig (karthiknadig)

    added

    needs PR

    on Sep 25, 2019
16. ghost removed

    triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

    on Sep 25, 2019
17. Karthik Nadig (karthiknadig)

    changed the title [-]Use `conda run` in the debug adapter[/-] [+]Spike: Use `conda run` in the debug adapter[/+] on Sep 25, 2019
18. Karthik Nadig (karthiknadig)

    modified the milestones: 2019 - September Sprint 2, 2019 - October Sprint 1 on Sep 25, 2019
19. Eric Snow (ericsnowcurrently)

    self-assigned this

    on Sep 30, 2019
20. Eric Snow (ericsnowcurrently)

    changed the title [-]Spike: Use `conda run` in the debug adapter[/-] [+]Use `conda run` in the debug adapter[/+] on Sep 30, 2019
21. Eric Snow (ericsnowcurrently)

    removed their assignment

    on Sep 30, 2019
22. ericsnowcurrently commented on Sep 30, 2019

    

    Eric Snow (ericsnowcurrently)

    on Sep 30, 2019

    More actions

    As noted earlier, we are going to leave the old debug adapter alone.
23. Eric Snow (ericsnowcurrently)

    closed this as completedon Sep 30, 2019
24. ghost removed

    needs PR

    on Sep 30, 2019
25. lock

    locked as resolved and limited conversation to collaborators on Oct 7, 2019