Skip to content

Add an option to run/debug all the parametrizations of a tests when clicking on "Run/Debug Test (Multiple)"  #5608

Closed

Description

@luabud

We could add an option the drop-down menu for running all the parametrizations when clicking on the code lenses below:

image

image

Activity

  1. ghost added
    triage-neededNeeds assignment to the proper sub-team
    on May 11, 2019
  2. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on May 14, 2019
  3. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on May 14, 2019
  4. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on May 14, 2019
  5. phloose commented on Nov 14, 2019

    @phloose

    This would be an nice feature! Maybe if there are multiple tests provide another code lens option like "Run all X Tests (Multiple)" or something like that, where X is the number of parametrized tests.

    EDIT:
    If you provide some help on writing tests, or a hint where i can find existing tests that test the codelens feature, i would prepare a pull request.

  6. DonJayamanne commented on Nov 20, 2019

    @DonJayamanne

    Luciana Abud (@luabud) Brett Cannon (@brettcannon)
    I think we'll end up with too many code lenses. For testing alone we'll have 3 code lenses on the one method.
    Languages add code lenses for # of references, code complexity, & the like. We might want to re-consider adding yet another code lens

    I think 3 code lenses for one single feature (testing) is too many.
    Install gitlens and a couple of other extensions, then we have too many even now.

    Suggestion: How about we drop (Multple) from the code lenses. Do we need it?

  7. phloose commented on Nov 20, 2019

    @phloose

    I actually like the codelenses for parametrized tests so that you can select single tests to run or debug. Maybe as you said Don Jayamanne (@DonJayamanne) drop the (Multiple) because you actually see that there is a parametrized test, which then would clean up the appearance. What bothered me is that you cannot run all single parametrized tests in a row with a quick action (like the code lens). This is the main reason for proposing the third option "Run All" in #8682.

  8. DonJayamanne commented on Nov 20, 2019

    @DonJayamanne

    reason for proposing the third option "Run All" in

    This could also be another item (first item) in the drop down list, instead of adding another code lens.

  9. phloose commented on Nov 20, 2019

    @phloose

    Yeah could also be a solution! I thought it would be more intuitive and fast that you don't have to click on Run Test and then move the mouse up to the drop down list to select that Run All command. Just my five cents ;)

  10. phloose commented on Nov 20, 2019

    @phloose

    If you decide against the third code lens option i could work on the "Run All" drop down element!

  11. luabud commented on Nov 21, 2019

    @luabud
    MemberAuthor

    Woohoo 🎉 thanks Philipp Loose (@phloose) for taking interest in this PR!
    I agree with Don, we already have enough code lenses as it is 😅 let's make "Run all" be the first item in the drop down list.

  12. phloose commented on Nov 21, 2019

    @phloose

    OK, i will try and prepare something for that dropdown option!

  13. phloose commented on Nov 23, 2019

    @phloose

    Don Jayamanne (@DonJayamanne) Luciana Abud (@luabud) i opened a pull request for the discussed option. I am keen for input and improvements from your side!

  14. phloose commented on Dec 12, 2019

    @phloose

    Luciana Abud (@luabud) as the pull request got merged shouldn't this be closed?

  15. luabud commented on Dec 12, 2019

    @luabud
    MemberAuthor

    Yes, thanks for bringing it up :)

  16. locked as resolved and limited conversation to collaborators on Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions