Repository navigation
Switch logging for pixi search from error to warning #23710
Description
Currently the extension prints an error if it cannot find pixi envs, it should instead warn and only give full info on verbose mode to reduce noise in the output panel.
2024-06-26 11:52:57.554 [error] Reading directory to watch failed [Error: ENOENT: no such file or directory, scandir '/Users/eleanorboyd/vscode-python/.pixi/envs'
at Object.readdirSync (node:fs:1515:3)
at t.readdirSync (node:electron/js2c/node_init:2:11289)
at /Users/eleanorboyd/.vscode-insiders/extensions/ms-python.python-2024.9.2024062601-darwin-arm64/out/client/extension.js:2:574446
at /Users/eleanorboyd/.vscode-insiders/extensions/ms-python.python-2024.9.2024062601-darwin-arm64/out/client/extension.js:2:574637
at Array.map (<anonymous>)
at d.initWatchers (/Users/eleanorboyd/.vscode-insiders/extensions/ms-python.python-2024.9.2024062601-darwin-arm64/out/client/extension.js:2:574355)
at async d.ensureWatchersReady (/Users/eleanorboyd/.vscode-insiders/extensions/ms-python.python-2024.9.2024062601-darwin-arm64/out/client/extension.js:2:536827)] {
errno: -2,
syscall: 'scandir',
code: 'ENOENT',
path: '/Users/eleanorboyd/vscode-python/.pixi/envs'
}
2024-06-26 11:52:57.554 [error] Dir "/Users/eleanorboyd/vscode-python/.pixi/envs" is not watchable (directory does not exist)
Activity
[-]switch logging for pixi search[/-][+]Switch logging for pixi search from error to warning[/+]karthiknadig commentedon Jun 26, 2024
Bas Zalmstra (@baszalmstra) Tim de Jager (@tdejager)
baszalmstra commentedon Jul 9, 2024
Should we just change this line here:
vscode-python/src/client/pythonEnvironments/base/locators/lowLevel/fsWatchingLocator.ts
Line 35 in a5c539d
Or move the logging below the if statement for when the directory doesnt exist?
karthiknadig commentedon Jul 9, 2024
You can just change the function to
traceVerbose, I think the location is fine.anthonykim1 commentedon Sep 24, 2024
I'm closing this as its completed by this PR in august: #23942 and https://github.com/microsoft/vscode-python/pull/23937/files