python_files/testing_tools/unittest_discovery.py has a Tornado hack w/ no reference to an issue to replace the hack

vscode-python/python_files/testing_tools/unittest_discovery.py

Lines 13 to 23 in 209d6bd

    
           def get_sourceline(obj): 
        
               try: 
        
                   s, n = inspect.getsourcelines(obj) 
        
               except: 
        
                   try: 
        
                       # this handles `tornado` case we need a better 
        
                       # way to get to the wrapped function. 
        
                       # This is a temporary solution 
        
                       s, n = inspect.getsourcelines(obj.orig_method) 
        
                   except: 
        
                       return "*"

Those bare except statements are also extremely broad.

this code will no longer be used once the test rewrite is finished and the old code is deleted.

remove pre-rewrite testing code (microsoft#24568)

Navigation Menu

Repository navigation

`python_files/testing_tools/unittest_discovery.py` has a Tornado hack w/ no reference to an issue to replace the hack #23050

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def get_sourceline(obj):
	try:
	s, n = inspect.getsourcelines(obj)
	except:
	try:
	# this handles `tornado` case we need a better
	# way to get to the wrapped function.
	# This is a temporary solution
	s, n = inspect.getsourcelines(obj.orig_method)
	except:
	return "*"

python_files/testing_tools/unittest_discovery.py has a Tornado hack w/ no reference to an issue to replace the hack #23050

Description

Activity

eleanorjboyd commented on Mar 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`python_files/testing_tools/unittest_discovery.py` has a Tornado hack w/ no reference to an issue to replace the hack #23050