Skip to content

REPL failure code decorator persists on successful code  #22811

Closed
#22867
Closed
REPL failure code decorator persists on successful code #22811
#22867
Assignees
anthonykim1
Labels
area-replbugIssue identified by VS Code Team member as probable bugon-testplanAdded to test plantriage-neededNeeds assignment to the proper sub-team

Description

@cwebster-99
Courtney Webster (cwebster-99)
opened on Jan 30, 2024

Tested on WSL and Codespaces and experienced the same issue. Code decorators appear as normal until you get a failure and then all subsequent code has a failure indicator even if successful. When using the Run Previous Command, the keyboard interrupt produces a failure decorator and then causes the similar behavior for subsequent code runs.

Repro:

  • Send code to the REPL and observe the code decorators that appear
  • Send a line that will result in a failure
  • Observe the failure decorator that appears as expected
  • Send code that should be successful
  • Observe the failure decorator that persists

Repro for run previous command bug:

  • Send a few lines of code to the REPL
  • Trigger the run previous command
  • Run a previous statement
  • Observe the failure decorator that persists

Codespaces:

repl_shell_integration_bug.mp4

WSL:
shellintegrationbug

Activity

  1. Courtney Webster (cwebster-99)
    added
    bugIssue identified by VS Code Team member as probable bug
    area-repl
    on Jan 30, 2024
  2. Courtney Webster (cwebster-99)
    assigned
    Anthony Kim (anthonykim1)
    on Jan 30, 2024
  3. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Jan 30, 2024

  4. anthonykim1 commented on Feb 7, 2024

    @anthonykim1
    Anthony Kim (anthonykim1)
    on Feb 7, 2024

    There are two parts to this issue:

    1. The wrongly set/cached success/failure decoration
    2. KeyboardInterrupt that you are seeing
    1. Should be fixed with PR this iteration
    2. This is expected behavior (check pwsh run recent history you will see its equivalent 'control c'), but I will look into ways of possibly suppressing this keyboard interrupted error in the middle of a REPL session.
  5. Anthony Kim (anthonykim1)
    closed this as completedin #22867on Feb 7, 2024
  6. Anthony Kim (anthonykim1)
    added a commit that references this issue on Feb 7, 2024

    Fix Run Recent Command Caching Issue (#22867)

    d674a17
  7. github-actions
    added
    on-testplanAdded to test plan
    on Feb 16, 2024
  8. github-actions
    locked as resolved and limited conversation to collaborators on Mar 23, 2024
  9. Wes McKinney (wesm)
    added 2 commits that reference this issue on Mar 28, 2024

    Merged PR posit-dev/positron-python#395: Merge upstream: `v2024.2.0`

    d822c25

    Merged PR posit-dev/positron-python#395: Merge upstream: `v2024.2.0`

    c976f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-replbugIssue identified by VS Code Team member as probable bugon-testplanAdded to test plantriage-neededNeeds assignment to the proper sub-team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions