Reliably detect whether shell integration is working or not when prepending PATH #22439

Activity

1. Kartik Raj (karrtikr)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   area-terminal

   needs PRReady to be worked onReady to be worked on

   on Nov 8, 2023
2. Kartik Raj (karrtikr)

   self-assigned this

   on Nov 8, 2023
3. Kartik Raj (karrtikr)

   added this to the November 2023 milestone on Nov 8, 2023
4. Kartik Raj (karrtikr)

   changed the title [-]Reliably detect whether shell integration is working or not when prepending environment variable[/-] [+]Reliably detect whether shell integration is working or not when prepending `PATH`[/+] on Nov 8, 2023
5. mkoohafkan commented on Nov 8, 2023

   

   Michael Koohafkan (mkoohafkan)

   on Nov 8, 2023

   More actions

   For PowerShell see also microsoft/vscode#174021
6. karrtikr commented on Nov 8, 2023

   

   Kartik Raj (karrtikr)

   on Nov 8, 2023

   Author

   More actions

   Michael Koohafkan (@mkoohafkan) Thanks, although here we're tackling this issue in a more general way. Your issue should be solved in VS Code Insiders once #22440 is merged.
7. Kartik Raj (karrtikr)

   closed this as completedin #22440on Nov 8, 2023
8. Kartik Raj (karrtikr)

   added a commit that references this issue on Nov 8, 2023

   Reliably detect whether shell integration is working (#22440)

   ...

   2a976e3
9. github-actions

   removed

   needs PRReady to be worked onReady to be worked on

   on Nov 8, 2023
10. karrtikr commented on Nov 22, 2023

    

    Kartik Raj (karrtikr)

    on Nov 22, 2023

    Author

    More actions

    Michael Koohafkan (@mkoohafkan) Can you please verify the #22418 is fixed in pre-release?
11. Kartik Raj (karrtikr)

    added

    author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue author

    verification-neededVerification of issue is requestedVerification of issue is requested

    on Nov 22, 2023
12. karrtikr commented on Nov 29, 2023

    

    Kartik Raj (karrtikr)

    on Nov 29, 2023

    Author

    More actions

    This is not working currently due to microsoft/vscode#199611.
13. 6 remaining items

    Load more
14. Kartik Raj (karrtikr)

    added

    needs PRReady to be worked onReady to be worked on

    and removed

    author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue author

    on Nov 29, 2023
15. João Moreno (joaomoreno)

    removed this from the December 2023This milestone has been deleted milestone on Dec 11, 2023
16. karrtikr commented on Feb 6, 2024

    

    Kartik Raj (karrtikr)

    on Feb 6, 2024

    Author

    More actions

    Alternative approach: Look for shell integration sequences using terminalDataWriteEvent when terminal starts up.
17. Kartik Raj (karrtikr)

    added this to the February 2024 milestone on Feb 6, 2024
18. karrtikr commented on Feb 7, 2024

    

    Kartik Raj (karrtikr)

    on Feb 7, 2024

    Last edited by karrtikr

    Author

    More actions

    Blocked on microsoft/vscode#204616, seems like the issue is either specific to Powershell or Windows.
19. Kartik Raj (karrtikr)

    closed this as completedin #22872on Feb 7, 2024
20. Kartik Raj (karrtikr)

    added a commit that references this issue on Feb 7, 2024

    Use terminal data write event to figure out whether shell integration…

    ...

    4030717
21. karrtikr commented on Feb 7, 2024

    

    Kartik Raj (karrtikr)

    on Feb 7, 2024

    Author

    More actions

    Can be verified through some of the triage items as they come up.
22. Kartik Raj (karrtikr)

    added

    verifiedVerification succeededVerification succeeded

    on Feb 7, 2024
23. github-actions

    locked as resolved and limited conversation to collaborators on Mar 10, 2024
24. Wes McKinney (wesm)

    added 4 commits that reference this issue on Mar 28, 2024

    Merged PR posit-dev/positron-python#277: Merge vscode-python 2023.22 …

    ...

    7dd0e33

    Merged PR posit-dev/positron-python#395: Merge upstream: `v2024.2.0`

    ...

    d822c25

    Merged PR posit-dev/positron-python#277: Merge vscode-python 2023.22 …

    ...

    439aafc

    Merged PR posit-dev/positron-python#395: Merge upstream: `v2024.2.0`

    ...

    c976f74