Smart send often doesn't work when file contain Python2 code #22318

Activity

1. Daniel Imms (Tyriar)

   assigned

   Anthony Kim (anthonykim1)

   on Oct 24, 2023
2. github-actions

   added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Oct 24, 2023
3. Tyriar commented on Oct 24, 2023

   

   Daniel Imms (Tyriar)

   on Oct 24, 2023

   Author

   More actions

   This happens with and without:

   "python.experiments.enabled": true, 
   "python.experiments.optInFrom": ["pythonREPLSmartSend"], 
   
4. anthonykim1 commented on Oct 24, 2023

   

   Anthony Kim (anthonykim1)

   on Oct 24, 2023

   Last edited by anthonykim1

   More actions

   Daniel Imms (@Tyriar) What python version are you using?
   Does it also crash your VS Code?
   Would you mind sending me what code you are shift+entering on? Having hard time reproducing it.
5. github-actions

   added

   info-neededIssue requires more information from posterIssue requires more information from poster

   on Oct 24, 2023
6. anthonykim1 commented on Oct 25, 2023

   

   Anthony Kim (anthonykim1)

   on Oct 25, 2023

   Last edited by anthonykim1

   More actions

   Daniel Imms (@Tyriar) The reason why this didn't work(for the file provided in slack specifically) is because the test file (one mentioned in Slack) that were being used to test smart send feature: https://github.com/microsoft/vscode/blob/3d7ff4a237b5eccf6bedc9902d75a0e228cc742d/extensions/vscode-colorize-tests/test/colorize-fixtures/test.py#L51, contained code block:

   def beliebig(x, y, *mehr):
       print "x=", x, ", x=", y
       print "mehr: ", mehr
   

   which is only valid in Python2.

   Minimum official support we have is Python3.8 and above, and end_lineno attribute from the AST module is only supported on Python3.8 and above. So it make sense why shift+enter did not "do" anything when the file contained the mentioned code segment.

   Smart Send would error out on Python2 code above. I think Python2 is no longer supported as of January 1st, 2020, hence make sense AST doesn't pickup Python2 code properly and manages to messed up parsing of the other contents of the given Python file as well.

   When you shift+enter on the any part of the Python file (some other Python3 code block that were in the file), the smart send logic and Python standard library module AST has to parse through the file in order to collect, and hence allow me to perform smart selection logic, and in that process it errors out. It also make sense that normal explicit highlighting selection will work because we don't have to parse through Python file like we have to for Smart Send (and hence smart selection) logic.

   Commenting out the Python2 code should allow you to use Smart Send without this issue!
   Thanks for testing, once again.

   Edit: Incoming message/warning/notification + user setting in regards to smart send on file with outdated Python code and toggling smart send on/off.
7. Anthony Kim (anthonykim1)

   changed the title [-]Smart send often doesn't work[/-] [+]Smart send often doesn't work when file contain Python2 code[/+] on Oct 25, 2023
8. Anthony Kim (anthonykim1)

   closed this as completedon Oct 25, 2023
9. Anthony Kim (anthonykim1)

   closed this as not plannedon Oct 25, 2023
10. Tyriar commented on Oct 25, 2023

    

    Daniel Imms (Tyriar)

    on Oct 25, 2023

    Author

    More actions

    Ideally we would fallback to something like sending just the line. Alternatively we could show some error notification, but I think just sending the line would be better.
11. Daniel Imms (Tyriar)

    reopened this on Oct 25, 2023
12. github-actions

    removed

    info-neededIssue requires more information from posterIssue requires more information from poster

    on Oct 25, 2023
13. anthonykim1 commented on Dec 7, 2023

    

    Anthony Kim (anthonykim1)

    on Dec 7, 2023

    More actions

    Closed as resolved with #22340 and #22341
14. Anthony Kim (anthonykim1)

    closed this as completedon Dec 7, 2023
15. github-actions

    locked as resolved and limited conversation to collaborators on Jan 7, 2024