Repository navigation
Show notification reaffirming Python extension still handles activation even if no prompt is shown #21793
Description
Activity
Notification:
Python extension automatically activates all terminals using environment variables, even when the name of the environment is not present in the terminal prompt. Learn more.
[ Got it! ]...where clicking got it will ensure we never show this notification again.
cc/ Courtney Webster (@cwebster-99) Daniel Imms (@Tyriar) Let me know if there's any feedback regarding notification text (including the "Learn more" wiki).
Python extension automatically activates all terminals using environment variables
"activates" seems ambiguous here. I think we should omit the method "environment variables" as it's a little technical and instead go into that detail in the docs if they care.
even when the name of the environment is not present in the terminal prompt
Instead of calling out the inconsistency where the name may not show, should we instead say you can hover the terminal tab to get information about the activation?
[ Got it! ]
"Don't Show Again" is the standard wording for the action
I'm not sure if extensions can access the built-in don't show again action:
Updated notification:
Python extension automatically activates all terminals using the selected environment. You can hover over the terminal tab to get information about the activation. Learn more.
I agree, this sounds better. Btw here's what learn more points to https://aka.ms/vscodePythonTerminalActivation.
"Don't Show Again" is the standard wording for the action
"Don't show again" is definitely the text to go with when there're multiple buttons in the prompt, but here we only have one button and this is an informational prompt, which is why I went with "got it". We used to have such a notification when trying to educate users about selecting interpreter:
Regardless, let me know if "Don't show again" is still preferred and I can change it back ✌️
I prefer "Don't Show Again" (with "Don't" and capital case), but PMs would be better as the final decision.
I agree, this sounds better. Btw here's what learn more points to https://aka.ms/vscodePythonTerminalActivation.
Eventually could this point at a new https://code.visualstudio.com/docs/python/environments section that describes how the environment variable activation works?
I think I prefer "Don't show again" even though this is informational. My main thought is I'm not sure users will understand that clicking "Got it!" will make the notification not show again if that makes sense. I think "Got it!" makes sense when we frame something as a tip.
Python extension automatically activates all terminals using the selected environment. You can hover over the terminal tab to get information about the activation. Learn more.
Small nit for the wording but "The Python extension automatically activates all terminals using the selected environment. You can hover over the terminal tab to see more information about the activation. Learn more."
Cool, btw Python extension historically prefers "Do not show again" instead of "Don't show again" for some reason I cannot recall Luciana Abud (@luabud)
Let me know if I should also rename all prompt buttons to "Don't show again" instead.
Eventually could this point at a new https://code.visualstudio.com/docs/python/environments section that describes how the environment variable activation works?
Once it stabilizes we'll definitely move some part of it if not the whole article there. I expect the limitations section can change quite frequently based on issue reports.
I think this was based on some standard we had defined in the past but it should be fine to change all of our "do not show again" to "don't show again" to shorten things up, especially given these are buttons.
Reacted by Daniel ImmsKartik Raj (@karrtikr) np, we can iterate over on vscode-docs pretty fast too. Not sure how often it's deployed from main but just commit to main for changes that are for the current version and vnext for the next version. Created microsoft/vscode-docs#6590 and stuck it on September
Reacted by Luciana AbudI feel less strongly when choosing between "Don't" and "Do not" 😄 so if it is a standard we already have happy to keep it!
Since we're all one product, let's standardize on
Don'tas that's what UX decided (I think) for VS Code core. Consistency is good 🙂Reacted by Luciana AbudThanks everyone. Until we're in experiment, this doc does not apply to all users hence we cannot move it to official VS Code docs just yet. But I'm tracking it to make sure we handle it: #20950.
Reacted by Daniel Imms and Luciana Abud- added a commit that references this issue
on Aug 15, 2023 - added a commit that references this issue
on Aug 30, 2023 - locked as resolved and limited conversation to collaborators
on Sep 29, 2023
When in
pythonTerminalEnvVarActivationexperiment:onDidOpenTerminaland show a notification explaining that the Python extension handles activation