Spike: Investigate using webworker for Python discovery #21755

Activity

1. Kartik Raj (karrtikr)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   area-environmentsFeatures relating to handling interpreter environmentsFeatures relating to handling interpreter environments

   needs spikeLabel for issues that need investigation before they can be worked on.Label for issues that need investigation before they can be worked on.

   on Aug 4, 2023
2. Kartik Raj (karrtikr)

   added this to the August 2023 milestone on Aug 4, 2023
3. Kartik Raj (karrtikr)

   self-assigned this

   on Aug 4, 2023
4. Frnchy1 commented on Aug 4, 2023

   

   Alain Rodier (Frnchy1)

   on Aug 4, 2023 via email · Hidden as spam

   show commentMore actions
5. Kartik Raj (karrtikr)

   modified the milestones: August 2023, September 2023 on Aug 28, 2023
6. karrtikr commented on Sep 14, 2023

   

   Kartik Raj (karrtikr)

   on Sep 14, 2023

   Last edited by karrtikr

   Author

   More actions

   Spike

   Discovery = locator + watcher + resolver

   vscode module is not available to use in worker threads, so we have to refactor them out. APIs we currently use:

   • Locator requires workspace.workspaceFolders and workspace.onDidChangeWorkspaceFolders
   • Watcher requires workspace.createFileSystemWatcher, EventEmitter, RelativePattern
   • Uri itself
   • ...maybe more

   Resolver & locator part are expensive, watcher can be outside. The issue right now is watcher is part of the locator, locator gives out existing environment locations and watcher returns whether there's an new env in those locations.
7. karrtikr commented on Sep 21, 2023

   

   Kartik Raj (karrtikr)

   on Sep 21, 2023

   Author

   More actions

   Spawning conda or "REG" binary (windows registry) can block the main thread for a few seconds:
   
8. karrtikr commented on Sep 21, 2023

   

   Kartik Raj (karrtikr)

   on Sep 21, 2023

   Last edited by karrtikr

   Author

   More actions

   Perf analysis of where time is spent on extension load, and how discovery impacts it:

   • discovery_fresh_startup.cpuprofile.txt
   • ls_with_discovery.cpuprofile.txt
   • ls_with_discovery_partial_proposal.cpuprofile.txt
   • ls_with_discovery_proposal.cpuprofile.txt
   • ls_without_discovery.cpuprofile.txt
9. Kartik Raj (karrtikr)

   added a commit that references this issue on Sep 21, 2023

   Fix bugs related to discovery blocking other features (#22041)

   ...

   00b198a
10. Kartik Raj (karrtikr)

    modified the milestones: September 2023, October 2023 on Sep 25, 2023
11. Eleanor Boyd (eleanorjboyd)

    added a commit that references this issue on Oct 2, 2023

    Fix bugs related to discovery blocking other features (microsoft#22041)

    ...

    8d4e30d
12. karrtikr commented on Oct 3, 2023

    

    Kartik Raj (karrtikr)

    on Oct 3, 2023

    Author

    More actions

    Spike results: #22146 (comment)
13. Kartik Raj (karrtikr)

    closed this as completedon Oct 3, 2023
14. Kartik Raj (karrtikr)

    modified the milestones: October 2023, September 2023 on Oct 3, 2023
15. Kartik Raj (karrtikr)

    added

    verifiedVerification succeededVerification succeeded

    on Oct 3, 2023
16. github-actions

    removed

    needs spikeLabel for issues that need investigation before they can be worked on.Label for issues that need investigation before they can be worked on.

    on Oct 3, 2023
17. github-actions

    locked as resolved and limited conversation to collaborators on Nov 3, 2023