You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
vscode.executeDocumentSymbolProvider seems to only work once (or at least only once in close succession) #2112
Executing vscode.executeDocumentSymbolProvider only returns all the symbols on the first call, successive calls return 0 symbols (at least within a small window)
Expected behavior
Executing vscode.executeDocumentSymbolProvider should return all the symbols no matter how many times (concurrently or not) it is called
Hi Eric Amodio (@eamodio)! Thanks for letting us know about this. Sorry about the delay and how DonJayamanne#553 slipped through the cracks when we moved the issues over to this repo.
Doing this I didn't have any problems (the outline filled out properly for each file). I also did not have any problems when I used the new language server. It could be that the results differ based on the contents of the file. We'd need examples of such files in order to proceed. Could you provide any?
FYI, there's a known issue with the language server that we're handling separately.
It seems the issue is connected to the new language server:
No GitLens + "python.jediEnabled": true: works;
No GitLens + "python.jediEnabled": false: no file outline will load anymore, and switching out of Explorer and back doesn't return the outline anymore
However, even when disabling the new language server and enabling GitLens the issue remains. Even more confusing, I'm not seeing the same behavior anymore even with the settings of the original issue:
GitLens + "python.jediEnabled": true (original issue): certain files load without problem, while others don't. Things I've tried to narrow down the differences:
Both files are in a repository tracked by GitLens: the one that breaks outline is in our main company repository, the one that works is in a new local repository;
Both files have the exact same content and name;
Both workspace folders use the same Python interpreter (from virtualenv)
I'm getting kind of lost here. As for the GitLens issue, it seems to have to do with the repository the file is in. If I can do anything to help debug this, please let me know!
Robert-Jan Bruintjes (@rjbruin), from the GitLens issue I noticed you are using VSCode 1.24.1. I've been trying to reproduce the problem using 1.25.1 (with no failures). Try upgrading VSCode and then see if the failure persists. Also, what version of the Python extension are you on right now? I'm using 2018.7.1 (the latest release). Thanks!
Open VSCode-Insiders within the directory I cloned.
Open one of the *.py files in the command_modules subtree.
Open different *.py files throughout the command_modules subtree, watching for outlines to appear.
Observed output:
On first visit to .py files, no outline is shown and none appear if you wait around.
On some subsequent visit (can be 2nd, or 3rd, or Nth) to files you've seen before the outline will appear.
Expected output:
On any visit to any *.py file, the outline is filled in. Perhaps even a 'loading' indicator.
This problem with Gitlens and vscode is present also when I am using jedi, and not the language server. Does that case make it a duplicate of #2334 too?
Activity
ericsnowcurrently commentedon Jul 31, 2018
Also related: gitkraken/vscode-gitlens#18.
ericsnowcurrently commentedon Jul 31, 2018
Hi Eric Amodio (@eamodio)! Thanks for letting us know about this. Sorry about the delay and how DonJayamanne#553 slipped through the cracks when we moved the issues over to this repo.
I've taken a stab at reproducing the issue, following the steps in gitkraken/vscode-gitlens#439:
Doing this I didn't have any problems (the outline filled out properly for each file). I also did not have any problems when I used the new language server. It could be that the results differ based on the contents of the file. We'd need examples of such files in order to proceed. Could you provide any?
FYI, there's a known issue with the language server that we're handling separately.
ericsnowcurrently commentedon Aug 1, 2018
(from Robert-Jan Bruintjes (@rjbruin) Aug 1, 2018, 5:39 AM MDT)
Eric Snow (@ericsnowcurrently) Thanks!
It seems the issue is connected to the new language server:
However, even when disabling the new language server and enabling GitLens the issue remains. Even more confusing, I'm not seeing the same behavior anymore even with the settings of the original issue:
I'm getting kind of lost here. As for the GitLens issue, it seems to have to do with the repository the file is in. If I can do anything to help debug this, please let me know!
ericsnowcurrently commentedon Aug 1, 2018
Robert-Jan Bruintjes (@rjbruin), from the GitLens issue I noticed you are using VSCode 1.24.1. I've been trying to reproduce the problem using 1.25.1 (with no failures). Try upgrading VSCode and then see if the failure persists. Also, what version of the Python extension are you on right now? I'm using 2018.7.1 (the latest release). Thanks!
Don Jayamanne (@DonJayamanne), any thoughts on this?
ericsnowcurrently commentedon Aug 1, 2018
Robert-Jan Bruintjes (@rjbruin), also, any VSCode logs you can provide would be helpful:
Logs
Output for
Pythonin theOutputpanel (View→Output, change the drop-down the upper-right of theOutputpanel toPython)Output from
Consoleunder theDeveloper Toolspanel (toggle Developer Tools on underHelp)9 remaining items
brettcannon commentedon Aug 3, 2018
Maybe we should re-orient this issue then to say the Outline view starts as empty upon initial load?
rjbruin commentedon Aug 6, 2018
Brett Cannon (@brettcannon) Sure. Do you need me to update the original issue?
d3r3kk commentedon Aug 14, 2018
Seems to be related to project size, I tested this issue out using the relatively sizeable project Microsoft/vsts-cli on Github.
Repro:
Observed output:
On first visit to .py files, no outline is shown and none appear if you wait around.
On some subsequent visit (can be 2nd, or 3rd, or Nth) to files you've seen before the outline will appear.
Expected output:
On any visit to any *.py file, the outline is filled in. Perhaps even a 'loading' indicator.
brettcannon commentedon Aug 14, 2018
Duplicate of #2334
sandipb commentedon Aug 17, 2018
This problem with Gitlens and vscode is present also when I am using jedi, and not the language server. Does that case make it a duplicate of #2334 too?
brettcannon commentedon Aug 20, 2018
Sandip Bhattacharya (@sandipb) feel free to open a new issue