Skip to content

"Activate Python Environment in Terminal created using the Extension" triggering on all terminals #20754

Closed
#20788
Closed
"Activate Python Environment in Terminal created using the Extension" triggering on all terminals#20754
#20788
Assignees
karrtikr
Labels
area-terminaldebtCode quality issuesneeds PRReady to be worked on
Milestone
March 2023

Description

@asportnoy
Albert Portnoy (asportnoy)
opened on Feb 25, 2023

The setting above (ID python.terminal.activateEnvironment) seems to be applying to all terminals, even ones not created by the extension.

Activity

  1. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Feb 25, 2023
  2. Karthik Nadig (karthiknadig)
    assigned
    Kartik Raj (karrtikr)
    on Feb 27, 2023

  3. karrtikr commented on Feb 27, 2023

    @karrtikr
    Kartik Raj (karrtikr)
    on Feb 27, 2023

    That's how that setting is currently intended to work, as it is how many of our Python users expect it. Is there any issue you're having with it?

  4. Kartik Raj (karrtikr)
    added
    info-neededIssue requires more information from poster
    area-terminal
    on Feb 27, 2023

  5. karrtikr commented on Feb 27, 2023

    @karrtikr
    Kartik Raj (karrtikr)
    on Feb 27, 2023

    Soon we'll be using #11039 to do it implicitly and stop sending commands to terminal, which may solve your issue.

  6. asportnoy commented on Feb 27, 2023

    @asportnoy
    Albert Portnoy (asportnoy)
    on Feb 27, 2023
    Author

    It sends a command to the start of each terminal which is a bit annoying. The language of the setting says it'll only apply to terminals created using the extension, so if that's not the case, the language should be updated.

  7. Kartik Raj (karrtikr)
    removed
    info-neededIssue requires more information from poster
    on Feb 28, 2023

  8. karrtikr commented on Mar 2, 2023

    @karrtikr
    Kartik Raj (karrtikr)
    on Mar 2, 2023

    Sure, we can update the language.

    It sends a command to the start of each terminal which is a bit annoying.

    We'll stop doing that with #11039.

  9. Kartik Raj (karrtikr)
    added
    debtCode quality issues
    needs PRReady to be worked on
    and removed
    triage-neededNeeds assignment to the proper sub-team
    on Mar 2, 2023
  10. Kartik Raj (karrtikr)
    added this to the March 2023 milestone on Mar 2, 2023
  11. Kartik Raj (karrtikr)
    closed this as completedin #20788on Mar 2, 2023

  12. asportnoy commented on Mar 2, 2023

    @asportnoy
    Albert Portnoy (asportnoy)
    on Mar 2, 2023
    Author

    Thank you! ❤️

  13. karrtikr commented on Mar 2, 2023

    @karrtikr
    Kartik Raj (karrtikr)
    on Mar 2, 2023

    Welcome!

  14. github-actions
    locked as resolved and limited conversation to collaborators on Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-terminaldebtCode quality issuesneeds PRReady to be worked on

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions