Repository navigation
Enable Pytest Rewrite to Users #20086
Description
Enable the pytest rewrite code and disable the old pytest coding method. This may also include doing the same for unittests but for reduced load these two might need to be at separate times. Dependencies between the two workflows should be analyzed to determine a best release schedule.
Activity
DetachHead commentedon Mar 7, 2024
is there a way for users to enable this themselves if the experiment isn't enabled for them? i wrote a pytest hook that relies on the new test adapter (pytest-dev/pytest-xdist#853 (comment)) and it would be nice if i could set something in
.vscode/settings.jsonto enable it for everyone in my team.edit: i just found
python.experiments.optInto, but it looks like that can only be configured on the user'ssettings.jsonand not the workspace oneeleanorjboyd commentedon Mar 27, 2024
DetachHead, the experiment should be enabled for all users by default- do you have a setting that might turn on this default behavior?
DetachHead commentedon Mar 28, 2024
looks like it was because i have
"telemetry.telemetryLevel"set to"off"DetachHead commentedon Apr 11, 2024
Eleanor Boyd (@eleanorjboyd) do experiments work differently on the insiders version of vscode? the
pythonTestAdapterexperiment seems to be disabled by default, even though i havetelemetry.telemetryLevelset toalleleanorjboyd commentedon Apr 15, 2024
It should be enabled for everyone on both stable and insiders. To confirm both your user and workspace settings do not reference anything about experiments?
DetachHead commentedon Apr 15, 2024
yep, no experiments or telemetry settings have been changed from the defaults. same thing happens on a colleague's PC with a fresh install. i even deleted everything in both my user and workspace
settings.jsonfiles just to be sureeleanorjboyd commentedon Apr 16, 2024
Luciana Abud (@luabud) could you take a look at this?
luabud commentedon Apr 16, 2024
Hmm it should be enabled on both Insiders and Public. A couple of things to check:
"workbench.enableExperiments":falseor"python.experiments.enabled":falseset in User, Workspace, Remote or Profile settings)I am also curious if there are any other experiments enabled, or if it's just this one that is disabled? You should be able to check this by opening the Python output channel ("Python: Show Output" command in the command palette) and looking into the first few lines there:
DetachHead commentedon Apr 16, 2024
yep, i'm on vscode
1.89.0-insiderand python extension2024.5.11021008 (pre-release)not sure where to find profile settings, but here's some screenshots of my user settings to show that there's no "modified elsewhere" messages on any of these settings:
no experiments showed up in the log, this is all i see:
luabud commentedon Apr 16, 2024
that's definitely unexpected. What happens if you explicitly add
"python.experiments.optInto": [ "pythonTestAdapter", ],to your settings?And you've downloaded VS Code from the official website, right?
DetachHead commentedon Apr 16, 2024
it works when i do that
yep
DetachHead commentedon Apr 16, 2024
also happened on a different colleague's PC with the stable version of vscode (1.88.1) and the stable version of the python extension (2024.4.1).
i checked all the same things on their PC. telemetry is enabled, no experiment settings have been changed, yet no experiments were active in the python output terminal.
luabud commentedon Apr 20, 2024
I've done some digging and the only hypothesis I could come up with is a mis configuration on our end. I made some changes so if that was the culprit, it should be fixed now. Would you mind removing the opt into setting, reloading VS Code and checking your Python Output to see if you have the experiment enabled?
If that didn't work, then I think #23241 is the fastest workaround we can provide for this issue indeed (cc Karthik Nadig (@karthiknadig))
DetachHead commentedon Apr 20, 2024
didn't work, still no experiments enabled for me on vscode insiders
in that case, i went ahead and made a PR: #23267
github-actions commentedon Jun 7, 2024
Hey Eleanor Boyd (@eleanorjboyd), this issue might need further attention.
Eleanor Boyd (@eleanorjboyd), you can help us out by closing this issue if the problem no longer exists, or adding more information.
remove pre-rewrite testing code (microsoft#24568)