Skip to content

Weird mix of quick pick and progress notification #19890

Closed
#19925
Closed
Weird mix of quick pick and progress notification#19890
#19925
Assignees
karthiknadig
Labels
area-environmentsFeatures relating to handling interpreter environmentsbugIssue identified by VS Code Team member as probable bugneeds PRReady to be worked onverifiedVerification succeeded
Milestone
September 2022

Description

@jrieken
Johannes Rieken (jrieken)
opened on Sep 27, 2022

Testing #19883

  • run "Create Env > venv"
  • while quick pick shows a progress notification appears telling me that quick pick is open.
  • that's very confusing UI, progress should only show after all input is gathered
Screen.Recording.2022-09-27.at.16.46.25.mov

Activity

  1. Johannes Rieken (jrieken)
    assigned
    Karthik Nadig (karthiknadig)
    on Sep 27, 2022

  2. jrieken commented on Sep 27, 2022

    @jrieken
    Johannes Rieken (jrieken)
    on Sep 27, 2022
    Author

    fyi David Dossett (@daviddossett) for quick quick UX guidelines

  3. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Sep 27, 2022

  4. daviddossett commented on Sep 27, 2022

    @daviddossett
    David Dossett (daviddossett)
    on Sep 27, 2022

    Agreed that we should avoid using progress notifications as a sort of await metaphor. Was this solving some sort of known issue e.g. users didn't know to make a selection?

  5. Karthik Nadig (karthiknadig)
    added this to the September 2022 milestone on Sep 28, 2022
  6. Karthik Nadig (karthiknadig)
    added
    bugIssue identified by VS Code Team member as probable bug
    area-environmentsFeatures relating to handling interpreter environments
    needs PRReady to be worked on
    and removed
    triage-neededNeeds assignment to the proper sub-team
    on Sep 28, 2022
  7. Karthik Nadig (karthiknadig)
    closed this as completedin #19925on Oct 3, 2022
  8. Karthik Nadig (karthiknadig)
    added a commit that references this issue on Oct 3, 2022

    Fix bugs found during TPI (#19925)

    ae63943
  9. Eleanor Boyd (eleanorjboyd)
    added a commit that references this issue on Oct 4, 2022

    Fix bugs found during TPI (microsoft#19925)

    51d80fe
  10. TylerLeonhardt
    added
    verifiedVerification succeeded
    on Oct 4, 2022
  11. github-actions
    locked as resolved and limited conversation to collaborators on Nov 4, 2022
  12. Wes McKinney (wesm)
    added a commit that references this issue on Mar 28, 2024

    Fix bugs found during TPI (microsoft/vscode-python#19925)

    56496ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-environmentsFeatures relating to handling interpreter environmentsbugIssue identified by VS Code Team member as probable bugneeds PRReady to be worked onverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions