Detection of flake8 is inconsitent/broken in some cases #1892

Activity

1. Randy Syring (rsyring)

   changed the title [-]Detection of flake8 extension is inconsitent/broken in some cases[/-] [+]Detection of flake8 is inconsitent/broken in some cases[/+] on Jun 7, 2018
2. DonJayamanne commented on Jun 7, 2018

   

   Don Jayamanne (DonJayamanne)

   on Jun 7, 2018

   More actions

   Rather than activating python in the Shell and then opening vscode, please configure the path to the python executable in settings.json in the python.pythonPath setting.

   See here https://code.visualstudio.com/docs/python/environments#_how-to-choose-an-environment
3. rsyring commented on Jun 7, 2018

   

   Randy Syring (rsyring)

   on Jun 7, 2018

   Author

   More actions

   Don Jayamanne (@DonJayamanne) While I like my method better, and hope it's supported, I tried what you suggested and it made no difference with the issue I reported.
4. DonJayamanne commented on Jun 7, 2018

   

   Don Jayamanne (DonJayamanne)

   on Jun 7, 2018

   More actions

   Please could you provide the contents of your settings.json?
5. Don Jayamanne (DonJayamanne)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   area-linting

   info-neededIssue requires more information from posterIssue requires more information from poster

   on Jun 7, 2018
6. rsyring commented on Jun 7, 2018

   

   Randy Syring (rsyring)

   on Jun 7, 2018

   Author

   More actions

   (tarsnap-prune-src-eTYfY8x1) rsyring@loftey:~/projects/tarsnap-prune-src$ cat .vscode/settings.json 
   {
       "python.pythonPath": "/data/tmp/virtualenvs/tarsnap-prune-src-eTYfY8x1/bin/python",
       "python.linting.flake8Enabled": false
   }
   (tarsnap-prune-src-eTYfY8x1) rsyring@loftey:~/projects/tarsnap-prune-src$ cat ~/.config/Code/User/settings.json 
   // Place your settings in this file to overwrite the default settings
   {
       "python.linting.enabled": true,
       "python.linting.pylintEnabled": false,
       "python.linting.flake8Enabled": true,
   
       // Configure glob patterns for excluding files and folders.
       "files.exclude": {
           // Defaults
           "**/.git": true,
           "**/.svn": true,
           "**/.hg": true,
           "**/.DS_Store": true,
   
           // Python related
           "**/.tox": true,
           "**/__pycache__": true,
           "**/*.pyc": true,
           "**/requirements/wheelhouse": true,
           "**/tags": true,
   
           // Other
           "**/.ci/**": true,
           "**/htmlcov": true
       },
       "editor.wrappingIndent": "none",
       "editor.renderIndentGuides": true,
       "files.insertFinalNewline": true,
       "files.trimTrailingWhitespace": true,
       "editor.rulers": [100]
       ,
       "window.zoomLevel": 1,
       "workbench.activityBar.visible": true,
       "editor.quickSuggestions": false,
       "editor.acceptSuggestionOnEnter": "smart",
       "editor.acceptSuggestionOnCommitCharacter": false,
       "editor.wordBasedSuggestions": true,
       "editor.wordWrapColumn": 100,
       "files.autoSave": "off",
       "vsicons.dontShowNewVersionMessage": true,
       "editor.minimap.enabled": false,
       "workbench.startupEditor": "newUntitledFile",
       "workbench.iconTheme": "vscode-icons",
       "[python]": {},
       "files.associations": {
           "**/ansible/group_vars/*": "yaml",
       },
       "symbolOutline.doSort": false,
       "symbolOutline.sortOrder": [
           "Class",
           "Function",
           "Module",
           "Constant",
           "Interface",
           "*",
           "Constructor",
           "Method"
       ],
       "docker.showExplorer": false,
       "symbolOutline.expandNodes": [
       ],
       "symbolOutline.doSelect": false,
       "editor.tabCompletion": true,
       "telemetry.enableTelemetry": false,
       "telemetry.enableCrashReporter": false,
       "cSpell.userWords": [
           "WSGI",
           "pipenv",
           "pytest",
           "repo"
       ]
   }
   

   Obviously, flake8 being disabled in the project's settings is because it's not working and the constant notice box is annoying.
7. DonJayamanne commented on Jun 7, 2018

   

   Don Jayamanne (DonJayamanne)

   on Jun 7, 2018

   Last edited by DonJayamanne

   More actions

   • Please could you provide the output from the following command in your terminal:
     /data/tmp/virtualenvs/tarsnap-prune-src-eTYfY8x1/bin/python -m flake8 --version

   • Please confirm you have restarted VS Code after making the changes to the settings.json file.
8. rsyring commented on Jun 7, 2018

   

   Randy Syring (rsyring)

   on Jun 7, 2018

   Last edited by rsyring

   Author

   More actions

   Well, I had deleted and reinstalled the virtualenv so I had to re-install flake8. Once I did so, I have:

   $ /data/tmp/virtualenvs/tarsnap-prune-src-eTYfY8x1/bin/python -m flake8 --version
   3.5.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0) CPython 3.6.5 on Linux
   

   And...amazingly?, I no longer have the problem with VS Code. I'm certain I tried that same workflow a couple times before I reported the issue and you can see in my terminal paste above that from inside VS Code, flake8 was installed. But...who knows, it's working now. Sorry to waste your time. :o/

   👍React with 👍1Reacted by Don Jayamanne
9. Don Jayamanne (DonJayamanne)

   closed this as completedon Jun 7, 2018
10. lock

    locked as resolved and limited conversation to collaborators on Jul 10, 2018