Skip to content

Consider removing extensions to prototypes of base types in favor of custom functions #18871

Open
Open
Consider removing extensions to prototypes of base types in favor of custom functions#18871
Labels
area-internalLabel for non-user facing issuesdebtCode quality issuesneeds PRReady to be worked on

Description

@karrtikr
Kartik Raj (karrtikr)
opened on Apr 6, 2022

We're editing the String interface itself by extending String.prototype, the issue with that is that other extensions which might share the same typing names might override our prototypes, for eg. fileToCommandArgument() also exists in Jupyter extension.

Convert all these to functions similar to like we have done with asyncFilter.

Activity

  1. Kartik Raj (karrtikr)
    added
    needs PR
    debtCode quality issues
    triage-neededNeeds assignment to the proper sub-team
    area-internalLabel for non-user facing issues
    on Apr 6, 2022
  2. Karthik Nadig (karthiknadig)
    removed
    triage-neededNeeds assignment to the proper sub-team
    on Apr 6, 2022
  3. Kartik Raj (karrtikr)
    changed the title [-]Convert typings in `extensions.ts` to functions[/-] [+]Consider removing extensions to prototypes of base types in favor of custom functions[/+] on Apr 7, 2022
  4. github-actions
    removed
    needs PR
    on Aug 9, 2022
  5. Kartik Raj (karrtikr)
    added
    needs PRReady to be worked on
    on Aug 9, 2022
  6. Kartik Raj (karrtikr)
    assigned
    Karthik Nadig (karthiknadig)
    on Aug 31, 2022

  7. lucyydotp commented on Jan 25, 2023

    @lucyydotp
    Lucy Poulton (lucyydotp)
    on Jan 25, 2023

    +1 for this, especially for replaceAll which is now standard and is breaking other plugins

  8. Karthik Nadig (karthiknadig)
    added a commit that references this issue on Feb 2, 2023

    Move `replaceAll` and `splitLines` out of string extensions. (#20626)

    9271136
  9. Karthik Nadig (karthiknadig)
    removed their assignment
    on Oct 30, 2023
  10. Wes McKinney (wesm)
    added 2 commits that reference this issue on Mar 28, 2024

    Merge remote-tracking branch 'upstream/main'

    50a5d67

    Merge remote-tracking branch 'upstream/main'

    06c5dad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-internalLabel for non-user facing issuesdebtCode quality issuesneeds PRReady to be worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions