Skip to content

Rename symbol misses symbols in formatted strings f"{foo}" #187

Closed

Description

From sdwarwick on September 25, 2017 13:25

Environment data

VS Code version: 1.16.1
Python Extension version: 0.7.0
Python Version: 3.6
OS and version: windows 10

Actual behavior

rename/refactor symbols completely misses symbols inside formatted text strings
f"{name}"

name is not found or changed

Expected behavior

clear from above

Steps to reproduce:

Logs

Output from Python output panel

no output

Output from Console window (Help->Developer Tools menu)

no output

Copied from original issue: DonJayamanne/pythonVSCode#1237

Activity

  1. DonJayamanne commented on Nov 14, 2017

    @DonJayamanne
    Author

    From KP (@kodalipraveen) on October 13, 2017 19:16

    This issue is also seen in Mac OS
    VSCode - 1.17.1
    Python Extension - 0.7.0

  2. MikhailArkhipov commented on Jan 11, 2018

    @MikhailArkhipov

    Same as #344, specifically davidhalter/jedi#930

  3. 4 remaining items

  4. FlavioCestari commented on Jun 2, 2018

    @FlavioCestari

    Waiting for this fix too. :)

  5. brettcannon commented on Jun 4, 2018

    @brettcannon
    Member

    Flávio Cestari (@FlavioCestari) this is going to require an upstream fix from rope.

  6. FlavioCestari commented on Jun 5, 2018

    @FlavioCestari

    It looks like the project is kind of stopped. The last release was in August, 2017.
    https://github.com/python-rope/rope/releases

    Is there any alternative?

  7. brettcannon commented on Jun 5, 2018

    @brettcannon
    Member

    Not at the moment. We are hoping to get our new analysis engine to handle refactorings/renamings.

  8. kleinicke commented on Feb 8, 2019

    @kleinicke
  9. ikariwing commented on Apr 11, 2019

    @ikariwing

    FYI (Info from Wei-Cheng Pan (@legnaleurc)): Oliver Newman (@orn688) already wrote a PR for rope to improve the symbol replacement in f-string , that PR is still not merged though. Thanks Oliver Newman (@orn688) :)

  10. DonJayamanne commented on Apr 18, 2019

    @DonJayamanne
    Author

    Closing, as this has been resolved upstream in rope.

  11. locked as resolved and limited conversation to collaborators on May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue identified by VS Code Team member as probable bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions