Repository navigation
Ensure language server is not blocked on discovery in the first session #18671
Description
If discovery takes a long time (#18200), it seems language server is not started until it has finished, even though it is not "blocked" on discovery NodeJS-wise. This prevents users from using the most basic features like the indexer, so they can't click through functions, variable definitions, etc.
In #18200 the user is blocked for about 15 mins, files are also on a shared network drive.
As language server activations takes less time, I think we can afford to postpone triggering discovery until after it has started. FYI Kim-Adeline Miguel (@kimadeline) as you're working on the new design to activate/deactivate language servers 🙂
Activity
wubdub commentedon Apr 15, 2022
Friendly ping on when this might be slated for development? My team of 200 hits this every morning and at lunch when we come back to our IDEs
karrtikr commentedon Apr 16, 2022
Unfortunately we haven't been able to prioritize it yet partly as it didn't get enough upvotes. Does the VSIXs provided in #18200 serve as a workaround?
wubdub commentedon Apr 19, 2022
Thanks Kartik Raj (@karrtikr), I can use the VSIX but I think it gets wiped every time I update the extension. If this post receives enough upvotes would it be prioritized?
karrtikr commentedon Apr 19, 2022
It'll have much more chances of being prioritized yes.
You can follow https://stackoverflow.com/a/63831525/8152786 to stop auto-updates for the Python extension.
wubdub commentedon May 10, 2022
karrtikr commentedon May 13, 2022
#18647 received enough upvotes as well and could work for you.
karrtikr commentedon May 13, 2022
wubdub #19102 now ensures auto discovery only happens in the first session and turns it off for subsequent sessions (given Jupyter is not installed). Try the latest pre-release, activate the extension, auto-discovery should no longer happen:
Let me know if that unblocks you.
[-]Ensure language server is not blocked on discovery[/-][+]Ensure language server is not blocked on discovery in the first session[/+]karrtikr commentedon Jun 3, 2022
This is now only a problem the first time a scope is opened, so could be an issue for the 1d users.
wubdub commentedon Jun 21, 2022
Sorry for the delay in getting back to you. Running v2022.9.11681004, I still have the same problem as I originally reported, the "Discovering Python Interpreters" with a spinning icon runs and during this time no language features are available (such as click to go to definition or syntax highlighting). Like before, the output terminal has logs like
> /XXX/shared/conda-envs/XXX-9f9d08bc8-990/bin/python ~/.vscode-server/extensions/ms-python.python-2022.9.11681004/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.9.11681004/pythonFiles/interpreterInfo.pyand spins for 10+ mins. This is looking at one file that previously was indexed the last time VSCode was openkarrtikr commentedon Jun 21, 2022
Do you have Jupyter extension installed? Note that still needs to be disabled.
wubdub commentedon Jun 22, 2022
Ah! Amazing I disabled Jupyter extension and now it is instant, thanks!