Skip to content

Support discovering multiple conda envs with same interpreter path #18357

Closed
#18427
Closed
Support discovering multiple conda envs with same interpreter path#18357
#18427
Assignees
karrtikr
Labels
area-environmentsFeatures relating to handling interpreter environmentsfeature-requestRequest for new features or functionalityon-testplanAdded to test planpartner ask
Milestone
March 2022

Description

@rchiodo
Rich Chiodo (rchiodo)
opened on Jan 25, 2022

Testing #18348

  1. Install conda
  2. Create two conda environments like so:
    conda create -n test1
    conda create -n test2
  3. Activate each and get python path. They should be the same
  4. Try using the API to find them.

They don't show up at all.

Activity

  1. Rich Chiodo (rchiodo)
    assigned
    Karthik Nadig (karthiknadig)
    on Jan 25, 2022
  2. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Jan 25, 2022

  3. karthiknadig commented on Jan 25, 2022

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Jan 25, 2022
    Member

    Rich Chiodo (@rchiodo) Which API did you use? if the extension was already loaded and you created these then you may have to call refreshInterpreters with clear cache.

    /cc Kartik Raj (@karrtikr) This seems like a underlying discovery issue.

  4. karthiknadig commented on Jan 25, 2022

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Jan 25, 2022
    Member

    Rich Chiodo (@rchiodo) conda create -n test1 does not create a conda environment with python in it.. you have to do conda create -n test1 python

    as you can see in my case there is no global python, so when i ask for python path after activation i get nothing:
    image

    but if you create conda environment with python then you get python path:
    image

  5. rchiodo commented on Jan 25, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on Jan 25, 2022
    Author

    I guess I have a global python set. I didn't get that error

  6. rchiodo commented on Jan 25, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on Jan 25, 2022
    Author

    Here's what I used to test:
    https://github.com/rchiodo/test-python-api

  7. karthiknadig commented on Jan 25, 2022

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Jan 25, 2022
    Member

    So if the environment itself does not have python, then we don't detect it or report anything about it. does this happen if you create it like this:

    conda create -n test1 python=3.9
conda create -n test2 python=3.9

    This is 3.9 because 3.10 in conda is broken.

  8. rchiodo commented on Jan 25, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on Jan 25, 2022
    Author

    No that works fine. That's usually how I have to create them in order to get them to work.

  9. rchiodo commented on Jan 25, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on Jan 25, 2022
    Author

    I mean this is a problem in the old API too.

  10. karthiknadig commented on Jan 25, 2022

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Jan 25, 2022
    Member

    Then this is working as expected. if the environment was not created to include python we don't detect those.

  11. rchiodo commented on Jan 25, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on Jan 25, 2022
    Author

    I don't think a customer is going to expect this. They have multiple conda environments but they don't see any of them.

  12. karthiknadig commented on Jan 25, 2022

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Jan 25, 2022
    Member

    You can have pure R environments in conda. Do we expect python extension to detect those? The python in environment created using conda create -n env1 is not the python from the environment. So, if we say install things in the python, then it would be the global python. Essentially, all installation will happen to that. I think that this might lead to greater problems with the python on the machine itself.

    /cc Brett Cannon (@brettcannon), Luciana Abud (@luabud) what do you suggest, should we list every conda environment or only those envs that have been setup with python. Currently we only detect those that have python in the env scripts/bin folder.

  13. rchiodo commented on Jan 25, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on Jan 25, 2022
    Author

    So, if we say install things in the python, then it would be the global python.

    This isn't true. If I do something like so:

    conda activate test1
conda install matplotlib

    It installs it here (even though python is global):

    C:\Users\aku91\miniconda3\envs\test1\Lib\site-packages\matplotlib>

    If I run python from that active environment, its sys path has been modified to use the conda location, and not the global:

    (test1) C:\Users\aku91\miniconda3\envs\test1\Lib\site-packages\matplotlib>python
Python 3.10.2 | packaged by conda-forge | (main, Jan 14 2022, 07:57:10) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.path
['', 'C:\\Users\\aku91\\miniconda3\\envs\\test1\\python310.zip', 'C:\\Users\\aku91\\miniconda3\\envs\\test1\\DLLs', 'C:\\Users\\aku91\\miniconda3\\envs\\test1\\lib', 'C:\\Users\\aku91\\miniconda3\\envs\\test1', 'C:\\Users\\aku91\\miniconda3\\envs\\test1\\lib\\site-packages']
>>>

    Conda supports this option just fine.

  14. Karthik Nadig (karthiknadig)
    added
    feature-requestRequest for new features or functionality
    on Jan 25, 2022
  15. Karthik Nadig (karthiknadig)
    removed their assignment
    on Jan 25, 2022

  16. 27 remaining items

  17. greazer commented on Jan 27, 2022

    @greazer
    Jim Griesmer (greazer)
    on Jan 27, 2022

    I just ran into this myself by accident.

    conda create ocaml-kernel
conda activate ocaml-kernel

    Everything seems fine, except I cannot find the environment in VS Code no matter what I do. Of course if I examine my environments with conda, I see it too. This is all highly confusing.

    conda env list
# conda environments:
#
                         C:\JupyterLab\resources\jlab_server
base                  *  C:\Users\jimg\anaconda3
covid-analysis           C:\Users\jimg\anaconda3\envs\covid-analysis
donsrepro                C:\Users\jimg\anaconda3\envs\donsrepro
jupyter-lab-test-env     C:\Users\jimg\anaconda3\envs\jupyter-lab-test-env
my-jupyter-lab           C:\Users\jimg\anaconda3\envs\my-jupyter-lab
myenv                    C:\Users\jimg\anaconda3\envs\myenv
ocaml-kernel             C:\Users\jimg\anaconda3\envs\ocaml-kernel
try-new-ipython          C:\Users\jimg\anaconda3\envs\try-new-ipython
xeus-python              C:\Users\jimg\anaconda3\envs\xeus-python

    I'm not sure I believe that this was never supported since most of the environments I've ever created I have used anaconda and I haven't specified a python version instance to install to it. In fact, the only reason I ever thought to do that was in case I wanted to use a different version of python than is available on the system. Perhaps I'm incorrect in that thinking, but it seems to make sense.

    Also note if I do an internet search for "How do I create a new conda environment" the first link I get is this:
    https://towardsdatascience.com/manage-data-science-and-machine-learning-environments-using-conda-42b9b2f0689a#:~:text=1%20Creating%20a%20New%20Conda%20Environment.%20You%20will,specify%20the%20version%20at%20the%20time%20of%20

    It basically says what I just said above. :)

  18. brettcannon commented on Jan 27, 2022

    @brettcannon
    Brett Cannon (brettcannon)
    on Jan 27, 2022
    Member

    Jim Griesmer (@greazer) it's never been supported by us; see https://code.visualstudio.com/docs/python/environments#_where-the-extension-looks-for-environments and point 7:

    Conda environments that contain a Python interpreter. VS Code does not show conda environments that don't contain an interpreter.

    conda itself may be manifesting the interpreter lazily upon conda install or something.

  19. Brett Cannon (brettcannon)
    added this to the February 2022 milestone on Feb 3, 2022
  20. Brett Cannon (brettcannon)
    added
    needs proposalNeed to make some design decisions
    partner ask
    and removed
    needs decision
    needs community feedbackAwaiting community feedback
    on Feb 3, 2022
  21. Kartik Raj (karrtikr)
    self-assigned this
    on Feb 8, 2022
  22. Kartik Raj (karrtikr)
    added
    needs PR
    and removed
    needs proposalNeed to make some design decisions
    on Feb 8, 2022
  23. Karthik Nadig (karthiknadig)
    modified the milestones: February 2022, March 2022 on Feb 23, 2022
  24. Kartik Raj (karrtikr)
    closed this as completedin #18427on Mar 21, 2022
  25. Kartik Raj (karrtikr)
    added
    on-testplanAdded to test plan
    on Mar 21, 2022
  26. github-actions
    locked as resolved and limited conversation to collaborators on Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-environmentsFeatures relating to handling interpreter environmentsfeature-requestRequest for new features or functionalityon-testplanAdded to test planpartner ask

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions