Skip to content

formatOnType will change two spaces before comment to one #1763

Closed

Description

@MisLink

Environment data

  • VS Code version: 1.23.1
  • Extension version (available under the Extensions sidebar): 2018.5.0-rc
  • OS and version: MacOS 10.13.4
  • Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
  • Relevant/affected Python packages and their versions: XXX

Actual behavior

a = 1  # two spaces before hash sign
<enter>
a = 1 # one left

Expected behavior

keep two spaces.

BTW, I notice this feature is being considered for deletion (#1586), is this kind of issues welcome?

Steps to reproduce:

  1. XXX

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

XXX

Activity

  1. brettcannon commented on May 29, 2018

    @brettcannon
    Member

    Yep, this info is still welcome as we're re-evaluating whether to keep or remove the feature so bug reports like this are still useful.

  2. MikhailArkhipov commented on May 29, 2018

    @MikhailArkhipov

    Missing Link (@MisLink) - yes please. This one is trivial to adjust. Do you have the feature on a regular basis?

  3. MisLink commented on May 30, 2018

    @MisLink
    Author

    well, use frequency of inline comments is very low for me.

  4. MikhailArkhipov commented on May 30, 2018

    @MikhailArkhipov

    I meant the feature itself (i.e. format on type) :-)

  5. MisLink commented on May 30, 2018

    @MisLink
    Author

    oh sorry, I misunderstand your meaning...
    I take this feature as my default global setting.

  6. locked as resolved and limited conversation to collaborators on Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-formattingbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions