Test discovery flow is unusual/weird #17094

Activity

1. Johannes Rieken (jrieken)

   assigned

   Karthik Nadig (karthiknadig)

   on Aug 24, 2021
2. github-actions

   added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Aug 24, 2021
3. Karthik Nadig (karthiknadig)

   removed their assignment

   on Aug 24, 2021
4. Karthik Nadig (karthiknadig)

   added

   area-testing

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   needs decision

   partner ask

   and removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Aug 24, 2021
5. chrisdias commented on Aug 26, 2021

   

   Chris Dias (chrisdias)

   on Aug 26, 2021

   More actions

   I found this list weird as well. What if I have tests in a file that don't follow the convention? I expected to see a list of files that were in my workspace, not a set of file patterns. Maybe its because the file pattern is bold and the description is grey, it makes it looks like files discovered in my workspace? Maybe just having the quick pick be the description would help? Not a blocker, but certainly made me stop and scratch my head.
6. jrieken commented on Aug 27, 2021

   

   Johannes Rieken (jrieken)

   on Aug 27, 2021

   Author

   More actions

   Maybe its because the file pattern is bold

   Yeah, I didn't understand if those presented patterns are all patterns that can be used. Or is this a list of commonly used patterns and hides the complexity of real glob patterns
7. Brett Cannon (brettcannon)

   added

   needs proposalNeed to make some design decisionsNeed to make some design decisions

   and removed

   needs decision

   on Feb 4, 2022
8. roblourens commented on Sep 6, 2023

   

   roblourens

   on Sep 6, 2023

   Member

   More actions

   I might have been a little confused by the flow if we didn't just go through it in detail this morning 😁. From #21845

   additionally the button "configure tests" found on the test explorer would be changed so it routed the user to a menu of the launch config options for testing

   So in the new proposal, you wouldn't guide the user through picking the test folder/pattern? How do they know to configure that?

   I don't necessarily mind the quick pick options as they currently are, it's probably nicer than asking the user to type a glob pattern. I assume the suggested patterns are typical for python projects. I just have a couple suggestions

   • After I go through this flow, open the config file to the side so I can see what you added, and see that I can customize it
   • Or show a notification with a button to open the file- we do this for some other flows that generate configuration for the user, like adding an ssh host automatically
9. Eleanor Boyd (eleanorjboyd)

   self-assigned this

   on Dec 4, 2023