Skip to content

Handle exclude lists in a test run request #16929

Closed

Description

See here for how exclude list is generated: microsoft/vscode#130522

  1. unittest: The underlying test adapter deals with testcases only. All we need to do is pass the right set of test case nodes (leaf nodes) to the runner in the extension.
  2. pytest : With the current test adapter we need to do additional work to prune the test tree to the a set of tests nodes that have no children in them that are in the exclude list. We can then pass the pruned nodes to the runner in the extension. A better approach here would be to update the test adapter to handle test runs based on the leaf nodes. This will also allow us to report test run progress, instead of running everything in bulk.

Activity

  1. eleanorjboyd commented on Oct 30, 2023

    @eleanorjboyd
    Member

    Hello! I have reviewed this issue and given the architectural changes of the testing rewrite, this issue should no longer exist on the rewrite. Therefore I am going to close this issue but please comment or open a new issue if you are still seeing a problem when you try this yourself!

    To use the rewrite yourself just add ”python.experiments.optInto": ["pythonTestAdapter"] to your user settings. You can confirm you have the rewrite enabled by setting your log level to trace, via the Developer: Set Log Level command in the command palette. Then check to see if Experiment 'pythonTestAdapter' is active is in your python logs.

    Thanks!

  2. locked as resolved and limited conversation to collaborators on Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-testingbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions