Repository navigation
Log ComSpec and add diagnostic to validate it #16692
Description
Activity
This should also log if PATH does not have
C:\Windows\System32. see related issue: #18138/cc Kartik Raj (@karrtikr) Just FYI.
Reacted by Kartik RajFor that user
ComSpecwas set #18138 (comment), I don't understand why node ran usingcmd.exeinstead of the value in the env variable. The fact whetherC:\Windows\System32is notPATHshould not matter as long as it was set.Documentation says
cmd.exeis only used as a fallback: https://nodejs.org/api/child_process.html#default-windows-shell.Perhaps it'll be sufficient to make sure it carries:
- A path that exists.
- It's a file and not a folder.
Note according to https://postgrespro.com/list/thread-id/1529515 it may also end with a semicolon, so some investigation may also be required to double check the possibilities of the values it can carry.
- changed the title
[-]Check and log ComSpec [/-][+]Log ComSpec and add diagnostic[/+]on Mar 31, 2022 - changed the title
[-]Log ComSpec and add diagnostic[/-][+]Log ComSpec and add diagnostic to validate it[/+]on Mar 31, 2022 - changed the title
[-]Log ComSpec and add diagnostic to validate it[/-][+]Log `ComSpec` and add diagnostic to validate it[/+]on Apr 4, 2022 Few known causes for such an error:
- Try setting the
"ComSpec"environment variable to a valid Command Prompt path in your system to fix it: https://aka.ms/AAk3djo. - Please edit
"Path"environment it to make sure it contains the "SystemRoot" subdirectories: https://aka.ms/AAk744c.
- Try setting the
Verification steps:
ONLY ON WINDOWS
- Set
ComSpecto an invalid value and load Python extension:
- Set
- locked as resolved and limited conversation to collaborators
on Apr 30, 2023
We see this often where ComSpec env variable is some how set to invalid path. We should detect this and log. This happens way too often.
Essentially the ENOENT (-4058) error with -c " " error usually means that Node exec tried to get default shell on Windows using
ComSpecand since ComSpec was wrong it was failing while trying to shell execute python commands.Originally posted by Karthik Nadig (@karthiknadig) in #16684 (comment)