Skip to content

Activation of environments does not work properly on multi-root environments #1476

Closed
#1691
Closed
Activation of environments does not work properly on multi-root environments#1476
#1691
Assignees
DonJayamanne
Labels
area-terminalbugIssue identified by VS Code Team member as probable bug
Milestone
May 2018

Description

@DonJayamanne
Don Jayamanne (DonJayamanne)
opened on Apr 24, 2018

This is because we aren't passing in the resource to ITerminalServiceFactory.getTerminalService();

Activity

  1. Don Jayamanne (DonJayamanne)
    added this to the May 2018 milestone on Apr 24, 2018
  2. Don Jayamanne (DonJayamanne)
    added
    bugIssue identified by VS Code Team member as probable bug
    needs PR
    area-terminal
    on Apr 24, 2018
  3. Don Jayamanne (DonJayamanne)
    self-assigned this
    on Apr 24, 2018
  4. Don Jayamanne (DonJayamanne)
    closed this as completedin #1691on May 21, 2018
  5. Don Jayamanne (DonJayamanne)
    added a commit that references this issue on May 21, 2018

    Ensure resource is passed into getTerminalService method (#1691)

    16acb4b
  6. Brett Cannon (brettcannon)
    added
    validate fix
    on May 24, 2018
  7. Derek Keeler (d3r3kk)
    removed
    validate fix
    on May 28, 2018
  8. lock
    locked as resolved and limited conversation to collaborators on Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-terminalbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions