Indentation not made after a function parameter list with a type hint #1461

Activity

1. Brett Cannon (brettcannon)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   needs PR

   area-formatting

   on Apr 24, 2018
2. Brett Cannon (brettcannon)

   added this to the April 2018 milestone on Apr 24, 2018
3. Don Jayamanne (DonJayamanne)

   assigned

   Don Jayamanne (DonJayamanne)

   and unassigned

   Don Jayamanne (DonJayamanne)

   on Apr 26, 2018
4. DonJayamanne commented on Apr 26, 2018

   

   Don Jayamanne (DonJayamanne)

   on Apr 26, 2018

   More actions

   Time to start writing unit tests for this.
5. DonJayamanne commented on Apr 26, 2018

   

   Don Jayamanne (DonJayamanne)

   on Apr 26, 2018

   Last edited by DonJayamanne

   More actions

   Here's what we have today:

   {
       beforeText: /^\s*(?:def|class|for|if|elif|else|while|try|with|finally|except)\b.*:\s*\S+/,
       action: { indentAction: IndentAction.None }
   },
   {
       beforeText: /^\s*(?:def|class|for|if|elif|else|while|try|with|finally|except|async)\b.*?:\s*/,
       action: { indentAction: IndentAction.Indent }
   },
   {
       beforeText: /^\s+(continue|break|return)\b.*/,
       afterText: /\s+$/,
       action: { indentAction: IndentAction.Outdent }
   }

   If we have the python code def foo(x: int):, then indentation breaks, even if we were to fix the second rule.

   I'd like to ensure we have covered all possible scenarios in this issue that can be used as test cases for each of the rules. Unfortunately we don't have any tests for these rules and I'm not comfortable making changes to this.

   Time to start hunting down all issues related to indentation and prepare a list of test cases/issues.
6. Brett Cannon (brettcannon)

   modified the milestones: April 2018, May 2018 on May 2, 2018
7. nottoseethesun commented on May 10, 2018

   

   Chris (nottoseethesun)

   on May 10, 2018

   More actions

   Is this unrelated to microsoft/monaco-editor#612 ?
8. DonJayamanne commented on May 24, 2018

   

   Don Jayamanne (DonJayamanne)

   on May 24, 2018

   More actions

   This seems to be caused by the implementation of editor.formatOnType
9. Don Jayamanne (DonJayamanne)

   closed this as completedin #1814on Jun 4, 2018
10. lock

    locked as resolved and limited conversation to collaborators on Jul 10, 2018