Repository navigation
Command 'python.analysis.restartLanguageServer' already exists #13441
Description
- Issue Type:
Bug - Extension Name:
python - Extension Version:
2020.8.101144 - OS Version:
Darwin x64 19.6.0 - VSCode version:
1.48.0
{
"messages": [],
"activationTimes": {
"codeLoadingTime": 966,
"activateCallTime": 367,
"activateResolvedTime": 2853,
"activationReason": {
"startup": false,
"extensionId": {
"value": "ms-python.python",
"_lower": "ms-python.python"
},
"activationEvent": "onLanguage:python"
}
},
"runtimeErrors": [
{
"name": "Error",
"message": "command 'python.analysis.restartLanguageServer' already exists"
}
]
}
Activity
[-]Extension :warning:[/-][+]Extension Bug[/+]yousefabuz17 commentedon Aug 15, 2020
Python 2020.8.101144 has many bugs, downgrade it to the one below it and everything should be fine. I issued a bug where the terminal would not accept any keyboard inputs and took me so long to realize what happened and its because python has a very recent update and downgrading it worked.
[-]Extension Bug[/-][+]Extension Bug: command 'python.analysis.restartLanguageServer' already exists[/+]kimadeline commentedon Aug 18, 2020
Hi Haden Moore (@HadenMoore), thank you for reaching out!
Does this behaviour happen consistently, and would yousefabuz17 downgrading suggestion work as a workaround for now?
I couldn't reproduce your issue on macOS 10.15.6, VS Code 1.48.0 and the Python extension 2020.8.101144, what is the value of the
python.languageServersetting in your user settings?Thank you!
leonhx commentedon Sep 23, 2020
Hi Kim-Adeline Miguel (@kimadeline) , I can constantly reproduce this issue: firstly add multiple folders to a workspace, open a file in one folder, then switch to a file from another folder(it is the key point), then an error occurs:
Version: 1.49.1
Commit: 58bb7b2331731bf72587010e943852e13e6fd3cf
Date: 2020-09-16T23:21:17.533Z (6 days ago)
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 19.6.0
ms-python: v2020.8.109390
kimadeline commentedon Sep 24, 2020
Hi (Leon) X. Huang (@leonhx),
Do you have a sample repo I could use to reproduce the issue, because I did not experience this issue with the steps you outlined:
What is what is the value of the
python.languageServersetting in your user settings and your workspace? Could you also copy the logs of thePythonoutput channel?Thanks!
leonhx commentedon Sep 28, 2020
Kim-Adeline Miguel (@kimadeline) , your GIF showed exactly what I meant. In my settings,
"python.languageServer": "Microsoft". My workspace has no custom settings.Here's a more specific reproduce procedure:
After the above steps finished, the logs from
Pythonchannel are:Environment:
6 remaining items
jakebailey commentedon Sep 28, 2020
Here. The entire implementation of this command is in the core extension. These commands are unknown to any LS directly, as the core extension manages the entire lifetime of the LS. #12952
The command gets registered in the LS manager. There should only be one of those at as time depending on the LS setting choice. I'm not sure how it's possible without some violation of the injection system.
kimadeline commentedon Sep 28, 2020
Yeah, I don't know how that happens either. Maybe something to do with multi-root workspaces and being called for each workspace?
In any case, it doesn't happen when using Pylance.
[-]Extension Bug: command 'python.analysis.restartLanguageServer' already exists[/-][+]Command 'python.analysis.restartLanguageServer' already exists when using MPLS[/+]rchiodo commentedon Nov 13, 2020
We get this on our smoke tests now.
https://github.com/microsoft/vscode-jupyter/runs/1398220329?check_suite_focus=true
It seems like it would happen when switching language servers if you don't restart.
jakebailey commentedon Nov 13, 2020
My patch that added this adds the command disposal, but it's likely that it's not actually getting disposed for some reason. Maybe it needs to be shoved down further so that it can only be available when the LS is running.
joyceerhl commentedon Nov 18, 2020
In the meantime maybe we could work around this in the commandRegistry by ensuring we call
registerCommandonce for each command? i.e. the commandRegistry would cache commands that it's already registered.jakebailey commentedon Nov 18, 2020
The problem would be if the old command is referencing a dead LS client, and therefore does nothing. I suppose that this is rare though where you need to change a setting (and are already in a bad state) and reload, so maybe it's not a huge problem.
joyceerhl commentedon Nov 18, 2020
Followed the repro steps above (set language server to 'Microsoft', cloned the two repos, opened a Python file from each). It seems like what's happening is the following:
I debugged this locally and can verify that the constructor was called twice, and that's likely the source of the duplicate command registrations. Can the ILanguageServerManager be made a singleton? If a new one really needs to be created per folder in a workspace, the command may need to be registered elsewhere.
jakebailey commentedon Nov 18, 2020
It can't be a singleton due to multi-root (one MPLS per root), but that's been broken for a while. The individual LS is what needs to be restarted, so having more than one technically breaks that down because you have to ask "which LS to restart". It's likely my implementation was too simple and needed to go and restart every running LS or something, and register the command elsewhere.
joyceerhl commentedon Nov 18, 2020
Yeah that makes sense, or maybe figure out which LS to restart based on the active root. In any case this error isn't fatal for our smoke tests so we don't urgently need a fix.
mfdeveloper commentedon Feb 1, 2021
+1 Kim-Adeline Miguel (@kimadeline) solution about use Pylance works!! But, I think that
"python.languageServer": "Microsoft"should work as well, right?[-]Command 'python.analysis.restartLanguageServer' already exists when using MPLS[/-][+]Command 'python.analysis.restartLanguageServer' already exists[/+]