ProcessService needs to be modified to use resolved environment variables #1339

Activity

1. Don Jayamanne (DonJayamanne)

   self-assigned this

   on Apr 7, 2018
2. Don Jayamanne (DonJayamanne)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   needs PR

   feature-*

   debtCode quality issuesCode quality issues

   and removed

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   on Apr 7, 2018
3. Don Jayamanne (DonJayamanne)

   added this to the April 2018 milestone on Apr 7, 2018
4. DonJayamanne commented on Apr 8, 2018

   

   Don Jayamanne (DonJayamanne)

   on Apr 8, 2018

   Last edited by DonJayamanne

   Author

   More actions

   Seems like a very large PR

   Option 1

   • Creating separate PRs
   • With additional tests
     Lets discuss the need for this later during the week.

   Option 2

   • Always pass environment variables to the exec and execObservable methods of IProcessService
   • Ensure to check this in PRs.
5. Don Jayamanne (DonJayamanne)

   modified the milestones: April 2018, May 2018 on Apr 18, 2018
6. Don Jayamanne (DonJayamanne)

   closed this as completedin #1342on May 8, 2018
7. Don Jayamanne (DonJayamanne)

   added a commit that references this issue on May 8, 2018

   Add factory class to create the process service (#1342)

   ...

   This issue will close once commit 128d231 is merged into the 'main' branch.

   128d231
8. lock

   locked as resolved and limited conversation to collaborators on Jul 11, 2018