Skip to content

Run CI tests on VSTS for PRs from core contributors of extension #1302

Closed

Description

The core contributors of the extension have to wait for the tests to pass before we can merge the tests (sometimes the tests take forever, sometimes they need to be re-run - due to flaky tests).
All of this slows down the time taken to merge a PR.

Solution:

  • Run tests on VSTS (all platforms)
  • Once tests pass, merge the PR
  • If tests fail on Master (AppVeyor or Travis), then
    • Restart tests
    • Worst case, identify the problem (identify why tests pass on VSTS and not on AppVeyor/Travis)
  • No changes to external contributors

Brett Cannon (@brettcannon) Mikhail Arkhipov (@MikhailArkhipov)
Thoughts

Activity

  1. changed the title [-]Run CI tests on VSTS for core contributors of extension[/-] [+]Run CI tests on VSTS for PRs from core contributors of extension[/+] on Apr 5, 2018
  2. brettcannon commented on Apr 5, 2018

    @brettcannon
    Member

    We should set up VSTS to get the 3-platform coverage anyway.

  3. DonJayamanne commented on Jun 4, 2018

    @DonJayamanne
    Author

    Closing as we've commenced work on this, and tracked in a separate issue.

  4. removed this from the June 2018 milestone on Jun 4, 2018
  5. locked as resolved and limited conversation to collaborators on Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions