Skip to content

Insiders build of the extension depends on unpackaged files #1292

Closed
#1312
Closed
Insiders build of the extension depends on unpackaged files#1292
#1312
Assignees
MikhailArkhipov
Labels
bugIssue identified by VS Code Team member as probable bug
Milestone
April 2018

Description

@patrys
Patryk Zawadzki (patrys)
opened on Apr 4, 2018

The nightly build tries to import ../test/constants from client/extension.js but the client/test dir is not part of the distribution.

Activity

  1. Don Jayamanne (DonJayamanne)
    assigned
    Mikhail Arkhipov (MikhailArkhipov)
    on Apr 4, 2018

  2. DonJayamanne commented on Apr 4, 2018

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on Apr 4, 2018

    Mikhail Arkhipov (@MikhailArkhipov) Please could you look into this. Should be a simple fix.
    Patryk Zawadzki (@patrys) Thanks for pointing this out.

  3. Don Jayamanne (DonJayamanne)
    added this to the April 2018 milestone on Apr 4, 2018
  4. Don Jayamanne (DonJayamanne)
    added
    bugIssue identified by VS Code Team member as probable bug
    needs PR
    feature-extension
    on Apr 4, 2018

  5. MikhailArkhipov commented on Apr 5, 2018

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Apr 5, 2018

    Yeah, it imports IS_ANALYSIS_ENGINE_TEST

  6. Mikhail Arkhipov (MikhailArkhipov)
    closed this as completedin #1312on Apr 5, 2018
  7. lock
    locked as resolved and limited conversation to collaborators on Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions