Skip to content

On type formatting errors for args and kwargs #1257

Closed

Description

    def notify(self, *args, **kwargs):
  • Use the above code
  • Place cursor after the :
  • Hit enter
    def notify(self, * args, ** kwargs):

Brett Cannon (@brettcannon) Personally I don't think we should be doing this. What do you think?

Activity

  1. MikhailArkhipov commented on Apr 2, 2018

    @MikhailArkhipov

    Probably should not be doing this.

  2. changed the title [-]On type formatting errors for args and kwards[/-] [+]On type formatting errors for args and kwargs[/+] on Apr 2, 2018
  3. MisLink commented on Apr 5, 2018

    @MisLink

    f-string has same issue.

    before:
    f'hello'

    after hit enter:
    f 'hello'

  4. brettcannon commented on Apr 5, 2018

    @brettcannon
    Member

    Is there a way to run the formatter through some well-formatted code to see what changes it would make? Like could we run it against the stdlib and see a diff of what would shift to see if we're making any other errors?

  5. MikhailArkhipov commented on Apr 5, 2018

    @MikhailArkhipov

    Write TS test and supply file line by line to formatter.formatLine as in suite('Formatting - line formatter'

  6. MisLink commented on Apr 9, 2018

    @MisLink

    I found another problem, it will break relative import:
    before:
    from . import something
    after:
    from.import something

    I tried development build, but it seems like it remove all formatting config.

  7. 7 remaining items

  8. locked as resolved and limited conversation to collaborators on Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-formattingbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions