Repository navigation
Wrong intellisense icons for variables. #117
Description
From AndyBay on May 13, 2017 11:45
Environment data
VS Code version: 1.12.1
Python Extension version: 0.6.4
Python Version: 3.6.1
OS and version: Windows 10
Currently (as seen under), arguments are using the "variable" icon and class variables are using the "reference" icon.
If we take that the icons for intellisense in Typescript is correct, and do following changes to the out\client\providers\jediProxy.js file.
Before:
pythonVSCodeTypeMappings.set('value', vscode.CompletionItemKind.Value);
pythonVSCodeTypeMappings.set('variable', vscode.CompletionItemKind.Variable);
After:
pythonVSCodeTypeMappings.set('value', vscode.CompletionItemKind.Field);
pythonVSCodeTypeMappings.set('variable', vscode.CompletionItemKind.Property);
This change "fixes" it as far as I can tell, except for the fact that both "variables" and "class variables" use the same icon when instead they should be variables => Variables and class variables => Field.
Also found these comments in the file :)
// What's this, can't remember,
// Great example of poorly written code (this whole file is a mess)
Copied from original issue: DonJayamanne/pythonVSCode#958
Activity
DonJayamanne commentedon Nov 13, 2017
AndyBay Apologies for never getting back to you on this.
I've been too busy looking into other issues and managed to over look something simple as this.
I'll look into this asap and try to include this into the next release.
MikhailArkhipov commentedon Dec 13, 2017
Jedi marks as
valueboth variables and class members. In order to select the right icon the code may need additional hints from the current editing context.MikhailArkhipov commentedon Mar 30, 2018
Not going to deal with Jedi. New analysis engine should provide proper icons as it does in VS.