Autocomplete should not appear within comments #1123

Activity

1. Don Jayamanne (DonJayamanne)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   area-intellisenseLSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc.LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc.

   needs PR

   on Mar 20, 2018
2. Don Jayamanne (DonJayamanne)

   added this to the March 2018 milestone on Mar 20, 2018
3. Don Jayamanne (DonJayamanne)

   assigned

   Don Jayamanne (DonJayamanne)

   and unassigned

   Don Jayamanne (DonJayamanne)

   on Mar 20, 2018
4. DonJayamanne commented on Mar 20, 2018

   

   Don Jayamanne (DonJayamanne)

   on Mar 20, 2018

   Author

   More actions

   Mikhail Arkhipov (@MikhailArkhipov)
   If a text range starts from 7 to 9, then why isn't 9 considered to be within this text range.

   See below test:
   https://github.com/Microsoft/vscode-python/blob/master/src/test/language/textRange.test.ts#L43
5. Don Jayamanne (DonJayamanne)

   removed their assignment

   on Mar 20, 2018
6. MikhailArkhipov commented on Mar 20, 2018

   

   Mikhail Arkhipov (MikhailArkhipov)

   on Mar 20, 2018

   More actions

   Specific to very end of a comment
7. Mikhail Arkhipov (MikhailArkhipov)

   self-assigned this

   on Mar 20, 2018
8. DonJayamanne commented on Mar 20, 2018

   

   Don Jayamanne (DonJayamanne)

   on Mar 20, 2018

   Last edited by brettcannon

   Author

   More actions

   Agreed, but this issue would occur majority of the time when typing in comments.
9. Mikhail Arkhipov (MikhailArkhipov)

   closed this as completedin #1129on Mar 20, 2018
10. Don Jayamanne (DonJayamanne)

    added a commit that references this issue on Mar 21, 2018

    Add news entry for #1096 and #1123

    ...

    2b4a246
11. Brett Cannon (brettcannon)

    added

    closed-fixed

    closed-verified fixed

    and removed

    closed-fixed

    on Mar 22, 2018
12. lock

    locked as resolved and limited conversation to collaborators on Jul 11, 2018