fix: Use launch configuration to resolve the classpath - #738
Merged
Merged
Conversation
Sheng Chen (jdneo)
requested review from
Yan Zhang (Eskibear) and
Jinbo Wang (testforstephen)
June 25, 2019 05:08
| return classpaths.toArray(new String[classpaths.size()]); | ||
| } | ||
|
|
||
| private static class JavaApplicationLaunchConfiguration extends LaunchConfiguration { |
Contributor
There was a problem hiding this comment.
JunitLaunchConfiguration?
| } | ||
|
|
||
| private static class JavaApplicationLaunchConfiguration extends LaunchConfiguration { | ||
| public static final String JAVA_APPLICATION_LAUNCH = "<?xml version=\"1.0\" encoding=\"UTF-8\"" + |
Contributor
There was a problem hiding this comment.
JUNIT_LAUNCH
| sourcepathProvider = "org.eclipse.m2e.launchconfig.sourcepathProvider"; | ||
| } else if (ProjectUtils.isGradleProject(project)) { | ||
| classpathProvider = "org.eclipse.buildship.core.classpathprovider"; | ||
| } |
Member
There was a problem hiding this comment.
what if not maven or gradle?
Member
Author
There was a problem hiding this comment.
Works as expected.
| } | ||
|
|
||
| private static String[] resolveClasspath(IJavaProject javaProject) throws CoreException { | ||
| // final JUnitLaunchConfigurationDelegate delegate = new JUnitLaunchConfigurationDelegate(); |
Member
There was a problem hiding this comment.
unused comments here?
Yan Zhang (Eskibear)
approved these changes
Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #623