fix - Update to Jacoco 0.8.14#1798
Merged
Merged
Conversation
Signed-off-by: Fred Bricon <[email protected]>
Contributor
|
@wenytang-ms and @chagong could you please review the PR? We may need to fix the failed tests via a separate PR. |
wenytang-ms
approved these changes
Oct 15, 2025
wenytang-ms
left a comment
wenytang-ms
left a comment
Contributor
There was a problem hiding this comment.
This PR also fix the ASM error in current npm run build-plugin issue
|
Thanks for fixing this! |
wenytang-ms
added a commit
that referenced
this pull request
Jun 8, 2026
…1872) * fix: ship org.objectweb.asm bundles to satisfy Jacoco 0.8.14 (#1866) The plugin and bundled Jacoco 0.8.14 require org.objectweb.asm [9.9.0,9.10.0), but the Eclipse platform/JDT-LS provided by vscode-java only ships asm 9.8.0. Since #1798 bumped Jacoco to 0.8.14 (asm 9.9) the asm bundle was never added to the copy allow-list in buildJdtlsExt.js, so it was never shipped in server/ nor registered in javaExtensions. At runtime this leaves com.microsoft.java.test.plugin and org.jacoco.core unresolved (BundleException: Unresolved requirement: org.objectweb.asm [9.9.0,9.10.0)), so the test plugin fails to load and no test UI appears. Add the org.objectweb.asm prefix to bundleList so asm, asm.commons and asm.tree 9.9.x are shipped with the extension and the requirement is satisfied independently of the platform-provided asm version. * refactor: list required asm bundles explicitly with _ suffix Address review feedback: bundleList prefixes are matched with startsWith, so the bare 'org.objectweb.asm' prefix could also match unrelated bundles like org.objectweb.asm.source_*. List the three bundles Jacoco 0.8.14 actually requires (asm, asm.commons, asm.tree) explicitly with the underscore delimiter, consistent with the other entries. Verified this is the complete closure: asm.commons/asm.tree import only asm, asm.tree and asm.signature (the latter is exported by the base asm bundle); nothing imports asm.analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1796
Update to Jacoco 0.8.14, which requires org.objectweb.asm:9.9.0.
The caveat is the extension requires vscode-java 1.47.0 to work, i.e. the current vscode-java pre-release, since jacoco no longer works with asm 9.8.0.