deduplicate diff test messages - #1521
Merged
Sheng Chen (jdneo) merged 3 commits intoJan 30, 2023
Merged
Sheng Chen (jdneo) merged 3 commits into
Sheng Chen (jdneo) merged 3 commits into
Conversation
Contributor
Author
|
Sheng Chen (@jdneo) first idea on how to fix the duplication of diff-test-messages for assertion errors, let me know what you think (not sure whether it's easier / less manual testing effort to incorporate this fix into #1519, or whether these two PRs should be kept separated?) |
Wladimir Hofmann (fladdimir)
force-pushed
the
fix/deduplicate-diff-test-messages
branch
from
January 29, 2023 15:01
7bc565a to
48512db
Compare
Wladimir Hofmann (fladdimir)
marked this pull request as ready for review
January 29, 2023 15:11
Sheng Chen (jdneo)
approved these changes
Jan 30, 2023
Sheng Chen (jdneo)
left a comment
Sheng Chen (jdneo)
left a comment
Member
There was a problem hiding this comment.
Thank you Wladimir Hofmann (@fladdimir) for your contribution!
The change looks good to me, and it makes the logic clearer than before. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1522