add proper error reporting for old testng - #1459
Merged
Merged
Conversation
TestNG version prior to like 6.7.x didn't failed the test method when related configuration method failed. Instead they skipped all the test methods which results in no error message in the Test Explorer. This change add those missing information if the test method is skipped followed by a configuration method failure.
Sheng Chen (jdneo)
self-requested a review
July 29, 2022 01:16
Sheng Chen (jdneo)
approved these changes
Jul 29, 2022
Sheng Chen (jdneo)
left a comment
Sheng Chen (jdneo)
left a comment
Member
There was a problem hiding this comment.
The fix works properly when exception happens at methods with TestNG configuration annotations.
Thank you for your contribution Gayan Perera (@gayanper)!
25 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNG version prior to like 6.7.x didn't failed the test method when
related configuration method failed. Instead they skipped all the
test methods which results in no error message in the Test Explorer.
This change add those missing information if the test method is skipped
followed by a configuration method failure.