Skip to content

fix: Should recognize test classes with '$' in their names - #1366

Merged
Sheng Chen (jdneo) merged 2 commits into
mainfrom
cs/issue-1364
Jan 25, 2022
Merged

fix: Should recognize test classes with '$' in their names#1366
Sheng Chen (jdneo) merged 2 commits into
mainfrom
cs/issue-1364

Conversation

@jdneo

@jdneo Sheng Chen (jdneo) commented Jan 25, 2022

Copy link
Copy Markdown
Member

fix #1364.

According to the API document, CompilationUnit.findDeclaringNode() will return null when:

  • if the corresponding node cannot be determined.
  • if bindings were not requested when this AST was built.

While ASTNodeSearchUtil works in this case.

Note: there are other usages for CompilationUnit.findDeclaringNode(), will consider if they should also be replaced to ASTNodeSearchUtil.

Signed-off-by: sheche [email protected]

@jdneo Sheng Chen (jdneo) added this to the 0.34.0 milestone Jan 25, 2022
@jdneo
Sheng Chen (jdneo) merged commit 49ea8ec into main Jan 25, 2022
@jdneo
Sheng Chen (jdneo) deleted the cs/issue-1364 branch January 25, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@testforstephen Jinbo Wang (testforstephen) testforstephen approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.34.0

Development

See More

Successfully merging this pull request may close these issues.

Test Explorer doesn't recognize test classes with '$' in their names

2 participants

@jdneo @testforstephen