feat: Add 'envFile' in test configuration - #1326
Merged
Merged
Conversation
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY),
Yan Zhang (Eskibear) and
Jinbo Wang (testforstephen)
November 2, 2021 05:02
Sheng Chen (jdneo)
force-pushed
the
cs/issue-1214
branch
from
November 2, 2021 05:15
906b3e2 to
af2d80e
Compare
| run: npm run build-plugin | ||
|
|
||
| - name: prepublish | ||
| run: npm run vscode:prepublish |
Contributor
There was a problem hiding this comment.
Suggest moving this part to script npm run test in package.json, to make it more convenient in development.
Member
Author
There was a problem hiding this comment.
Make sense
Think a little bit more, I would rather prefer leave the test script as it is now -- to make it be executed more quickly.
During development, we can keep the task watch running, then no need to prepublish it again and again when running tests.
Shi Chen (CsCherrYY)
previously approved these changes
Nov 2, 2021
Shi Chen (CsCherrYY)
left a comment
Shi Chen (CsCherrYY)
left a comment
Contributor
There was a problem hiding this comment.
please do not forget to update the wiki
Sheng Chen (jdneo)
force-pushed
the
cs/issue-1214
branch
from
November 2, 2021 06:29
af2d80e to
5ca36c2
Compare
Shi Chen (CsCherrYY)
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #1214