feat: Support generate tests from a source file - #1193
Merged
Merged
Conversation
Member
Author
|
test failed due to: redhat-developer/vscode-java#1929 |
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY),
Yan Zhang (Eskibear) and
Jinbo Wang (testforstephen)
May 6, 2021 03:33
Yan Zhang (Eskibear)
previously approved these changes
May 7, 2021
Yan Zhang (Eskibear)
left a comment
Yan Zhang (Eskibear)
left a comment
Member
There was a problem hiding this comment.
Overall LGTM. You took a big piece of code to do backend validation in getTestFullyQualifiedName. Just don't forget to add frontend validation in vscode.
Yan Zhang (Eskibear)
previously approved these changes
May 7, 2021
Jinbo Wang (testforstephen)
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #1172