Support toggling awt development in help center - #886
Merged
Merged
Conversation
Signed-off-by: sheche <[email protected]>
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY) and
Jinbo Wang (testforstephen)
as code owners
January 18, 2022 03:12
Yan Zhang (Eskibear)
previously approved these changes
Jan 18, 2022
Yan Zhang (Eskibear)
left a comment
Yan Zhang (Eskibear)
left a comment
Member
There was a problem hiding this comment.
LGTM.
Just wondering if we can simply add the entry in private groups, e.g. make it a getter, and the args value depends on this.props.isAwtDisabled. But I'm not sure if that would cause refresh of the whole page after you click the action.
Signed-off-by: sheche <[email protected]>
Member
Author
Good idea! This simplified the code and won't refresh the whole page |
Yan Zhang (Eskibear)
approved these changes
Jan 18, 2022
Closed
35 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new entry to toggle the awt development in the Student section of Help Center.
Signed-off-by: sheche [email protected]