feat: Support create JavaFX projects - #581
Merged
Merged
Conversation
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY) and
Yan Zhang (Eskibear)
January 11, 2022 08:47
Yan Zhang (Eskibear)
previously approved these changes
Jan 12, 2022
Contributor
|
I'm OK with this change, and there are some errors in the UI test about create command, I'll add a commit here to fix it. |
Shi Chen (CsCherrYY)
previously approved these changes
Jan 12, 2022
Signed-off-by: Sheng Chen <[email protected]>
Sheng Chen (jdneo)
force-pushed
the
cs/javafx
branch
from
January 13, 2022 06:45
1dbab50 to
fabc357
Compare
Shi Chen (CsCherrYY)
approved these changes
Jan 13, 2022
35 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of microsoft/vscode-java-pack#856
Signed-off-by: Sheng Chen [email protected]