Implement envFile (Issue #523) - #928
Merged
Merged
Conversation
|
|
|
How can I check your PR to see if it works for me ? |
Contributor
Author
Jinbo Wang (testforstephen)
self-requested a review
January 7, 2021 08:44
Jinbo Wang (testforstephen)
left a comment
Jinbo Wang (testforstephen)
left a comment
Contributor
There was a problem hiding this comment.
overall looks good.
Jinbo Wang (testforstephen)
approved these changes
Jan 13, 2021
Jinbo Wang (testforstephen)
left a comment
Jinbo Wang (testforstephen)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. thanks for your contribution.
|
Thanks for working on this, I've been waiting on somebody to handle that port for a while. I built and installed from this branch and it works great, except the edge case of clicking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented envFile to close #523
Uses some code from https://github.com/microsoft/vscode-js-debug to parse env files
Jinbo Wang (@testforstephen)