Delay registering codelens provider until java extension is activated - #632
Merged
Merged
Conversation
Signed-off-by: Jinbo Wang <[email protected]>
Jinbo Wang (testforstephen)
requested review from
Yan Zhang (Eskibear),
Rome Li (akaroml) and
Sheng Chen (jdneo)
August 16, 2019 03:02
Yan Zhang (Eskibear)
approved these changes
Aug 16, 2019
Member
There was a problem hiding this comment.
LGTM as a workaround.
Though it still cannot cover the below case:
I open the workspace, current active file is pom.xml, before language server is fully started, I quickly open a .java file. CodeLens still miss.
UPDATE:
Well, "onLanguage:java" ensure that the debugger only activate when current file is .java
Sheng Chen (jdneo)
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
fix #631