Add debug/toolbar button to reload changed classes - #586
Merged
Merged
Conversation
Signed-off-by: Jinbo Wang <[email protected]>
Signed-off-by: Jinbo Wang <[email protected]>
Jinbo Wang (testforstephen)
requested review from
Rome Li (akaroml),
Andy Xu(devdiv) (andxu) and
Yaohai Zheng (yaohaizh)
May 23, 2019 01:07
Signed-off-by: Jinbo Wang <[email protected]>
| "The hot code replace feature requires you to enable the autobuild flag, do you want to enable it?", | ||
| "Yes", "No"); | ||
| if (ans === "Yes") { | ||
| await autobuildConfig.update("enabled", true); |
Contributor
There was a problem hiding this comment.
What happen after enable it?
Contributor
Author
There was a problem hiding this comment.
current hcr doesn't take effect, you need click again.
Signed-off-by: Jinbo Wang <[email protected]>
| ], | ||
| "engines": { | ||
| "vscode": "^1.22.0" | ||
| "vscode": "^1.32.0" |
Contributor
There was a problem hiding this comment.
When is the features introduced in vscode for additional icons in debug toolbar?
Contributor
Author
There was a problem hiding this comment.
yes, 1.32 add the support to extend the debug toolbar buttons.
Yaohai Zheng (yaohaizh)
approved these changes
May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Close #559
Add a new debug settings
java.debug.settings.hotCodeReplaceto control how to trigger HCR. Defaults tomanual.