Skip to content

Add zh-tw locale - #1087

Merged
Jinbo Wang (testforstephen) merged 2 commits into
microsoft:mainfrom
MuTsunTsai:main
Dec 20, 2021
Merged

Jinbo Wang (testforstephen) merged 2 commits into
microsoft:mainfrom
MuTsunTsai:main

Conversation

@MuTsunTsai

Copy link
Copy Markdown
Contributor

Traditional Chinese locale.

@ghost

Deleted user (ghost) commented Nov 23, 2021 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@testforstephen Jinbo Wang (testforstephen) added this to the 0.38.0 milestone Dec 20, 2021
@testforstephen
Jinbo Wang (testforstephen) merged commit d9670bc into microsoft:main Dec 20, 2021
@testforstephen

Copy link
Copy Markdown
Contributor

Mu-Tsun Tsai (@MuTsunTsai) thanks for your contribution.

@Eskibear

Copy link
Copy Markdown
Member

Jinbo Wang (@testforstephen) Do we need to rename previous nls json file from zh to zh-cn?

@testforstephen

Copy link
Copy Markdown
Contributor

Is there any Best Practice about the nls naming in VS Code extensions?

@Eskibear

Copy link
Copy Markdown
Member

https://stackoverflow.com/questions/56420338/how-to-localise-vscode-extension

looks like CPP extension does a good job. full i18n support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants